Re: [PATCH] tools: fix libvirt-guests.sh text assignments

2020-08-22 Thread Andrea Bolognani
On Friday, August 21, 2020 10:05:21 AM, Christian Ehrhardt wrote: > > , and your > > suggested change would make these assignments work even on shells that do > > not apply special parsing rules for it. > > Thanks, I also have pushed this through a bunch of tests that use > libvirt-guests.sh on

Re: [PATCH] tools: fix libvirt-guests.sh text assignments

2020-08-21 Thread Christian Ehrhardt
On Thu, Aug 20, 2020 at 10:50 AM Michael Chapman wrote: > > On Thu, 20 Aug 2020, Christian Ehrhardt wrote: > > On Wed, Aug 19, 2020 at 12:15 PM Christian Ehrhardt > > wrote: > > > > > > In libvirt 6.6 stopping guests with libvirt-guests.sh is broken. > > > As soon as there is more than one guest

Re: [PATCH] tools: fix libvirt-guests.sh text assignments

2020-08-20 Thread Michael Chapman
On Thu, 20 Aug 2020, Christian Ehrhardt wrote: > On Wed, Aug 19, 2020 at 12:15 PM Christian Ehrhardt > wrote: > > > > In libvirt 6.6 stopping guests with libvirt-guests.sh is broken. > > As soon as there is more than one guest one can see > > `systemctl stop libvirt-guests` faiing and in the log

Re: [PATCH] tools: fix libvirt-guests.sh text assignments

2020-08-19 Thread Christian Ehrhardt
On Wed, Aug 19, 2020 at 12:15 PM Christian Ehrhardt wrote: > > In libvirt 6.6 stopping guests with libvirt-guests.sh is broken. > As soon as there is more than one guest one can see > `systemctl stop libvirt-guests` faiing and in the log we see: > libvirt-guests.sh[2455]: Running guests on

[PATCH] tools: fix libvirt-guests.sh text assignments

2020-08-19 Thread Christian Ehrhardt
In libvirt 6.6 stopping guests with libvirt-guests.sh is broken. As soon as there is more than one guest one can see `systemctl stop libvirt-guests` faiing and in the log we see: libvirt-guests.sh[2455]: Running guests on default URI: libvirt-guests.sh[2457]: