Re: [PATCH 0/2] qemu: migration corner case fix and cleanup

2020-10-06 Thread Nikolay Shirokovskiy
Polite ping On 14.09.2020 19:10, Nikolay Shirokovskiy wrote: > There is issue with second patch. Probably this unset/set was too mysterious > and I miss one point - we do need to call unset on error path as in case > of non p2p migration confirm step will not be called. > > So this need to be sq

Re: [PATCH 0/2] qemu: migration corner case fix and cleanup

2020-09-14 Thread Nikolay Shirokovskiy
There is issue with second patch. Probably this unset/set was too mysterious and I miss one point - we do need to call unset on error path as in case of non p2p migration confirm step will not be called. So this need to be squashed in: diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migra

Re: [PATCH 0/2] qemu: migration corner case fix and cleanup

2020-09-14 Thread Michal Privoznik
On 8/18/20 12:26 PM, Nikolay Shirokovskiy wrote: Nikolay Shirokovskiy (2): qemu: fix qemuMigrationSrcCleanup to use qemuMigrationJobFinish qemu: don't needlessly unset close callback during perform phase src/qemu/qemu_migration.c | 14 +++--- 1 file changed, 3 insertions(+), 11

Re: [PATCH 0/2] qemu: migration corner case fix and cleanup

2020-09-10 Thread Nikolay Shirokovskiy
Polite ping On 18.08.2020 13:26, Nikolay Shirokovskiy wrote: > Nikolay Shirokovskiy (2): > qemu: fix qemuMigrationSrcCleanup to use qemuMigrationJobFinish > qemu: don't needlessly unset close callback during perform phase > > src/qemu/qemu_migration.c | 14 +++--- > 1 file changed, 3

[PATCH 0/2] qemu: migration corner case fix and cleanup

2020-08-18 Thread Nikolay Shirokovskiy
Nikolay Shirokovskiy (2): qemu: fix qemuMigrationSrcCleanup to use qemuMigrationJobFinish qemu: don't needlessly unset close callback during perform phase src/qemu/qemu_migration.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) -- 1.8.3.1