Re: [PATCH 0/5] be consistent about error checking xmlNodeGetContent() return

2020-07-28 Thread Michal Privoznik
On 7/20/20 10:48 PM, Laine Stump wrote: Awhile back I noticed that calls to xmlNodeGetContent() from libvirt code were inconsistent in their handling of the returned pointer. Sometimes we would assume the return was always non-NULL (dereferencing with wild abandon without concern for the

[PATCH 0/5] be consistent about error checking xmlNodeGetContent() return

2020-07-20 Thread Laine Stump
Awhile back I noticed that calls to xmlNodeGetContent() from libvirt code were inconsistent in their handling of the returned pointer. Sometimes we would assume the return was always non-NULL (dereferencing with wild abandon without concern for the consequences), sometimes we would interpret NULL