Re: [PATCH 00/28] a bunch of domain_conf cleanup

2020-11-11 Thread Michal Privoznik
On 11/6/20 4:32 AM, Matt Coleman wrote: Most of this is making functions void that unnecessarily return an int. It also includes some conversion to GLib. Feel free to squash related commits, if you'd like. I left them separate to make it easier to review. Matt Coleman (28): domain_conf:

Re: [PATCH 00/28] a bunch of domain_conf cleanup

2020-11-11 Thread Matt Coleman
> On Nov 9, 2020, at 9:43 AM, Michal Privoznik wrote: > > Nice cleanup. But as I say in 03/28 I think we might want glib adoption to be > done in bigger chunks. Usually we rewrite VIR_ALLOC/VIR_REALLOC_N -> > g_new0()/g_renew() in one patch (might be coupled with g_free() except > VIR_FREE()

Re: [PATCH 00/28] a bunch of domain_conf cleanup

2020-11-10 Thread Michal Privoznik
On 11/11/20 8:18 AM, Matt Coleman wrote: On Nov 9, 2020, at 9:43 AM, Michal Privoznik wrote: Nice cleanup. But as I say in 03/28 I think we might want glib adoption to be done in bigger chunks. Usually we rewrite VIR_ALLOC/VIR_REALLOC_N -> g_new0()/g_renew() in one patch (might be coupled

Re: [PATCH 00/28] a bunch of domain_conf cleanup

2020-11-09 Thread Ján Tomko
On a Monday in 2020, Michal Privoznik wrote: On 11/6/20 4:32 AM, Matt Coleman wrote: Most of this is making functions void that unnecessarily return an int. It also includes some conversion to GLib. Feel free to squash related commits, if you'd like. I left them separate to make it easier to

Re: [PATCH 00/28] a bunch of domain_conf cleanup

2020-11-09 Thread Michal Privoznik
On 11/6/20 4:32 AM, Matt Coleman wrote: Most of this is making functions void that unnecessarily return an int. It also includes some conversion to GLib. Feel free to squash related commits, if you'd like. I left them separate to make it easier to review. Yeah, some might be squashed. 14

Re: [PATCH 00/28] a bunch of domain_conf cleanup

2020-11-06 Thread Neal Gompa
On Thu, Nov 5, 2020 at 10:33 PM Matt Coleman wrote: > > Most of this is making functions void that unnecessarily return an int. > It also includes some conversion to GLib. > > Feel free to squash related commits, if you'd like. I left them separate > to make it easier to review. > > Matt Coleman

[PATCH 00/28] a bunch of domain_conf cleanup

2020-11-05 Thread Matt Coleman
Most of this is making functions void that unnecessarily return an int. It also includes some conversion to GLib. Feel free to squash related commits, if you'd like. I left them separate to make it easier to review. Matt Coleman (28): domain_conf: make virDomainDiskSetDriver() void