Re: [PATCH 03/15] virBitmapToString|virBitmapNewString: Clarify semantics of the 'string'

2020-10-05 Thread Ján Tomko
On a Monday in 2020, Peter Krempa wrote: On Fri, Oct 02, 2020 at 17:44:13 +0200, Ján Tomko wrote: On a Friday in 2020, Peter Krempa wrote: > On Fri, Oct 02, 2020 at 13:17:17 +0200, Ján Tomko wrote: > > On a Friday in 2020, Peter Krempa wrote: > > > Clarify which bit is considered most significan

Re: [PATCH 03/15] virBitmapToString|virBitmapNewString: Clarify semantics of the 'string'

2020-10-05 Thread Peter Krempa
On Fri, Oct 02, 2020 at 17:44:13 +0200, Ján Tomko wrote: > On a Friday in 2020, Peter Krempa wrote: > > On Fri, Oct 02, 2020 at 13:17:17 +0200, Ján Tomko wrote: > > > On a Friday in 2020, Peter Krempa wrote: > > > > Clarify which bit is considered most significant in the bitmap and > > > > result

Re: [PATCH 03/15] virBitmapToString|virBitmapNewString: Clarify semantics of the 'string'

2020-10-02 Thread Ján Tomko
On a Friday in 2020, Peter Krempa wrote: On Fri, Oct 02, 2020 at 13:17:17 +0200, Ján Tomko wrote: On a Friday in 2020, Peter Krempa wrote: > Clarify which bit is considered most significant in the bitmap and > resulting string. Also be explicit that it's a hex string. > > Signed-off-by: Peter Kr

Re: [PATCH 03/15] virBitmapToString|virBitmapNewString: Clarify semantics of the 'string'

2020-10-02 Thread Peter Krempa
On Fri, Oct 02, 2020 at 13:17:17 +0200, Ján Tomko wrote: > On a Friday in 2020, Peter Krempa wrote: > > Clarify which bit is considered most significant in the bitmap and > > resulting string. Also be explicit that it's a hex string. > > > > Signed-off-by: Peter Krempa > > --- > > src/util/virbi

Re: [PATCH 03/15] virBitmapToString|virBitmapNewString: Clarify semantics of the 'string'

2020-10-02 Thread Ján Tomko
On a Friday in 2020, Peter Krempa wrote: Clarify which bit is considered most significant in the bitmap and resulting string. Also be explicit that it's a hex string. Signed-off-by: Peter Krempa --- src/util/virbitmap.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --

[PATCH 03/15] virBitmapToString|virBitmapNewString: Clarify semantics of the 'string'

2020-10-02 Thread Peter Krempa
Clarify which bit is considered most significant in the bitmap and resulting string. Also be explicit that it's a hex string. Signed-off-by: Peter Krempa --- src/util/virbitmap.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/util/virbitmap.c b/src/util/vir