Re: [PATCH 05/11] hyperv: create SCSI controllers when defining domains

2021-01-08 Thread Matt Coleman
> On Nov 26, 2020, at 9:42 AM, Daniel P. Berrangé wrote: > > You ought to pass def->controllers[i] into this method and validate > as many properties as practical. At very least validate the model > and report VIR_ERR_CONFIG_UNSUPPORTED for any you can't emulate. Hyper-V's SCSI controllers are

Re: [PATCH 05/11] hyperv: create SCSI controllers when defining domains

2021-01-08 Thread Daniel P . Berrangé
On Fri, Jan 08, 2021 at 02:50:25AM -0500, Matt Coleman wrote: > > On Nov 26, 2020, at 9:42 AM, Daniel P. Berrangé wrote: > > > > You ought to pass def->controllers[i] into this method and validate > > as many properties as practical. At very least validate the model > > and report

Re: [PATCH 05/11] hyperv: create SCSI controllers when defining domains

2020-11-26 Thread Daniel P . Berrangé
On Tue, Nov 24, 2020 at 02:48:34PM -0500, Matt Coleman wrote: > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 51 ++ > 1 file changed, 51 insertions(+) > > diff --git a/src/hyperv/hyperv_driver.c

[PATCH 05/11] hyperv: create SCSI controllers when defining domains

2020-11-24 Thread Matt Coleman
Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 559b60d3df..1ad52e598a 100644 ---