Re: [PATCH 07/22] qemu: Reject 'preserve' action for 'on_reboot'/'on_poweroff'/'on_crash'

On Wed, Sep 15, 2021 at 10:57:23 +0100, Daniel P. Berrangé wrote: > On Wed, Sep 15, 2021 at 11:47:04AM +0200, Christian Borntraeger wrote: > > > > > > On 15.09.21 11:45, Christian Borntraeger wrote: > > > On 24.08.21 16:44, Peter Krempa wrote: > > > > The qemu driver didn't ever implement any

Re: [PATCH 07/22] qemu: Reject 'preserve' action for 'on_reboot'/'on_poweroff'/'on_crash'

On Wed, Sep 15, 2021 at 11:47:04AM +0200, Christian Borntraeger wrote: > > > On 15.09.21 11:45, Christian Borntraeger wrote: > > On 24.08.21 16:44, Peter Krempa wrote: > > > The qemu driver didn't ever implement any meaningful handling for the > > > 'preserve' action. > > > > > > Forbid the

Re: [PATCH 07/22] qemu: Reject 'preserve' action for 'on_reboot'/'on_poweroff'/'on_crash'

On 15.09.21 11:45, Christian Borntraeger wrote: On 24.08.21 16:44, Peter Krempa wrote: The qemu driver didn't ever implement any meaningful handling for the 'preserve' action. Forbid the flag in the qemu def validator and update the documentation to be factual. Signed-off-by: Peter Krempa

Re: [PATCH 07/22] qemu: Reject 'preserve' action for 'on_reboot'/'on_poweroff'/'on_crash'

On 24.08.21 16:44, Peter Krempa wrote: The qemu driver didn't ever implement any meaningful handling for the 'preserve' action. Forbid the flag in the qemu def validator and update the documentation to be factual. Signed-off-by: Peter Krempa NACK. It is a perfectly sane usecase to have

[PATCH 07/22] qemu: Reject 'preserve' action for 'on_reboot'/'on_poweroff'/'on_crash'

The qemu driver didn't ever implement any meaningful handling for the 'preserve' action. Forbid the flag in the qemu def validator and update the documentation to be factual. Signed-off-by: Peter Krempa --- docs/formatdomain.rst| 3 +-- src/qemu/qemu_validate.c | 10 ++ 2 files