Re: [PATCH 1/3] qemu: implementation of transient option for qcow2 file

2020-08-06 Thread Masayoshi Mizuma
On Thu, Aug 06, 2020 at 12:09:20PM +0200, Peter Krempa wrote: > On Sun, Jul 19, 2020 at 22:56:50 -0400, Masayoshi Mizuma wrote: > > On Sat, Jul 18, 2020 at 08:06:00AM +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 20:55:29 -0400, Masayoshi Mizuma wrote: > > > > Thank you for your review.

Re: [PATCH 1/3] qemu: implementation of transient option for qcow2 file

2020-08-06 Thread Peter Krempa
On Sun, Jul 19, 2020 at 22:56:50 -0400, Masayoshi Mizuma wrote: > On Sat, Jul 18, 2020 at 08:06:00AM +0200, Peter Krempa wrote: > > On Thu, Jul 16, 2020 at 20:55:29 -0400, Masayoshi Mizuma wrote: > > > Thank you for your review. > > > > > > On Tue, Jul 07, 2020 at 06:36:23AM -0500, Eric Blake

Re: [PATCH 1/3] qemu: implementation of transient option for qcow2 file

2020-07-19 Thread Masayoshi Mizuma
On Sat, Jul 18, 2020 at 08:06:00AM +0200, Peter Krempa wrote: > On Thu, Jul 16, 2020 at 20:55:29 -0400, Masayoshi Mizuma wrote: > > Thank you for your review. > > > > On Tue, Jul 07, 2020 at 06:36:23AM -0500, Eric Blake wrote: > > > On 7/7/20 2:12 AM, Peter Krempa wrote: > > > > > > > You can

Re: [PATCH 1/3] qemu: implementation of transient option for qcow2 file

2020-07-18 Thread Peter Krempa
On Thu, Jul 16, 2020 at 20:55:29 -0400, Masayoshi Mizuma wrote: > Thank you for your review. > > On Tue, Jul 07, 2020 at 06:36:23AM -0500, Eric Blake wrote: > > On 7/7/20 2:12 AM, Peter Krempa wrote: > > > > > You can install a qcow2 overlay on top of a raw file too. IMO the > > > implications

Re: [PATCH 1/3] qemu: implementation of transient option for qcow2 file

2020-07-16 Thread Masayoshi Mizuma
Thank you for your review. On Tue, Jul 07, 2020 at 06:36:23AM -0500, Eric Blake wrote: > On 7/7/20 2:12 AM, Peter Krempa wrote: > > > You can install a qcow2 overlay on top of a raw file too. IMO the > > implications of using allow that. > > > > As said above I'd strongly prefer if the overlay

Re: [PATCH 1/3] qemu: implementation of transient option for qcow2 file

2020-07-07 Thread Peter Krempa
On Tue, Jul 07, 2020 at 06:36:23 -0500, Eric Blake wrote: > On 7/7/20 2:12 AM, Peter Krempa wrote: > > > > 1) the virDomainBlockCopy operation flattens the backing chain into the > > top level only. This means that must be stripped or the > > operation rejected, as otherwise shutting down the VM

Re: [PATCH 1/3] qemu: implementation of transient option for qcow2 file

2020-07-07 Thread Eric Blake
On 7/7/20 2:12 AM, Peter Krempa wrote: You can install a qcow2 overlay on top of a raw file too. IMO the implications of using allow that. As said above I'd strongly prefer if the overlay is created in qemu using the blockdev-create blockjob (there is already infrastructure in libvirt to

Re: [PATCH 1/3] qemu: implementation of transient option for qcow2 file

2020-07-07 Thread Peter Krempa
On Mon, Jul 06, 2020 at 14:20:23 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Here is the implementation of transient option for qcow2 file. > This gets available directive in domain xml file > like as: > > > > > > > > > The internal

[PATCH 1/3] qemu: implementation of transient option for qcow2 file

2020-07-06 Thread Masayoshi Mizuma
From: Masayoshi Mizuma Here is the implementation of transient option for qcow2 file. This gets available directive in domain xml file like as: The internal procedure is as follows. When the qemu command line options are built, a new qcow2 image is