Re: [PATCH 10/13] util: hash: Reimplement virHashTable using GHashTable

2020-10-27 Thread Daniel P . Berrangé
On Tue, Oct 27, 2020 at 01:09:38PM +0100, Peter Krempa wrote: > On Tue, Oct 27, 2020 at 10:04:33 +, Daniel Berrange wrote: > > On Tue, Oct 27, 2020 at 10:53:12AM +0100, Peter Krempa wrote: > > > On Mon, Oct 26, 2020 at 16:08:34 +, Daniel Berrange wrote: > > > > On Mon, Oct 26, 2020 at

Re: [PATCH 10/13] util: hash: Reimplement virHashTable using GHashTable

2020-10-27 Thread Peter Krempa
On Tue, Oct 27, 2020 at 10:04:33 +, Daniel Berrange wrote: > On Tue, Oct 27, 2020 at 10:53:12AM +0100, Peter Krempa wrote: > > On Mon, Oct 26, 2020 at 16:08:34 +, Daniel Berrange wrote: > > > On Mon, Oct 26, 2020 at 04:45:50PM +0100, Peter Krempa wrote: > > > > Glib's hash table provides

Re: [PATCH 10/13] util: hash: Reimplement virHashTable using GHashTable

2020-10-27 Thread Daniel P . Berrangé
On Tue, Oct 27, 2020 at 10:53:12AM +0100, Peter Krempa wrote: > On Mon, Oct 26, 2020 at 16:08:34 +, Daniel Berrange wrote: > > On Mon, Oct 26, 2020 at 04:45:50PM +0100, Peter Krempa wrote: > > > Glib's hash table provides basically the same functionality as our hash > > > table. > > > > > >

Re: [PATCH 10/13] util: hash: Reimplement virHashTable using GHashTable

2020-10-27 Thread Peter Krempa
On Mon, Oct 26, 2020 at 16:08:34 +, Daniel Berrange wrote: > On Mon, Oct 26, 2020 at 04:45:50PM +0100, Peter Krempa wrote: > > Glib's hash table provides basically the same functionality as our hash > > table. > > > > In most cases the only thing that remains in the virHash* wrappers is > >

Re: [PATCH 10/13] util: hash: Reimplement virHashTable using GHashTable

2020-10-26 Thread Daniel P . Berrangé
On Mon, Oct 26, 2020 at 04:45:50PM +0100, Peter Krempa wrote: > Glib's hash table provides basically the same functionality as our hash > table. > > In most cases the only thing that remains in the virHash* wrappers is > NULL-checks of '@table' argument as glib's hash functions don't tolerate >

[PATCH 10/13] util: hash: Reimplement virHashTable using GHashTable

2020-10-26 Thread Peter Krempa
Glib's hash table provides basically the same functionality as our hash table. In most cases the only thing that remains in the virHash* wrappers is NULL-checks of '@table' argument as glib's hash functions don't tolerate NULL. In case of iterators, we adapt the existing API of iterators to