Re: [PATCH 4/5] virt-host-validate: Call VIR_HOST_VALIDATE_FAILURE() more frequently

2021-06-08 Thread Fabiano FidĂȘncio
[...] > > if (virFileExists("/dev/sev")) { > @@ -513,6 +515,7 @@ int virHostValidateSecureGuests(const char *hvname, > virHostMsgFail(level, > "AMD Secure Encrypted Virtualization appears to > be " > "disabled in

[PATCH 4/5] virt-host-validate: Call VIR_HOST_VALIDATE_FAILURE() more frequently

2021-06-08 Thread Michal Privoznik
Ideally, every virHostMsgFail() would be coupled with VIR_HOST_VALIDATE_FAILURE() so that the failure is correctly propagated to the caller. However, in virHostValidateSecureGuests() we are either ignoring @level and returning 0 directly (no error), or not returning at all, relying on 'return 0'