Re: [PATCH libvirt v1 3/6] conf: fix ZPCI address auto-generation on s390

2020-06-16 Thread Andrea Bolognani
On Tue, 2020-06-16 at 12:43 +0200, Shalini Chellathurai Saroja wrote: > On 6/3/20 12:58 PM, Andrea Bolognani wrote: > > On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote: > > > +++ b/tests/qemuxml2xmloutdata/hostdev-vfio-zpci-multidomain-many.xml > > > @@ -39,7 +39,7 @@ > > >

Re: [PATCH libvirt v1 3/6] conf: fix ZPCI address auto-generation on s390

2020-06-16 Thread Shalini Chellathurai Saroja
Hi Andrea, Thank you for the review. On 6/3/20 12:58 PM, Andrea Bolognani wrote: On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote: +++ b/src/conf/domain_addr.c @@ -145,12 +145,18 @@ static void virDomainZPCIAddressReleaseIds(virDomainZPCIAddressIdsPtr zpciIds,

Re: [PATCH libvirt v1 3/6] conf: fix ZPCI address auto-generation on s390

2020-06-03 Thread Andrea Bolognani
On Thu, 2020-04-09 at 12:31 +0200, Shalini Chellathurai Saroja wrote: > +++ b/src/conf/domain_addr.c > @@ -145,12 +145,18 @@ static void > virDomainZPCIAddressReleaseIds(virDomainZPCIAddressIdsPtr zpciIds, > virZPCIDeviceAddressPtr addr) > { > -if (!zpciIds ||

[PATCH libvirt v1 3/6] conf: fix ZPCI address auto-generation on s390

2020-04-09 Thread Shalini Chellathurai Saroja
Currently, if uid/fid is specified as zero by the user, it is treated as if the value is not specified. This bug is fixed by introducing two boolean values to identify if uid and fid are specified by the user. Also, if either uid or fid is specified by the user, it is incorrectly assumed that