On 11/13/20 4:28 PM, Jonathon Jongsma wrote:
On Fri, 13 Nov 2020 12:09:26 +0100
Shalini Chellathurai Saroja wrote:
Hi Jonathon,
Thank you for the quick review:-)
On 11/12/20 5:27 PM, Jonathon Jongsma wrote:
+
+
+
+
+
+
It seems that you're unnecessarily chan
Jonathon Jongsma [2020-11-13, 09:28AM -0600]:
> That said, I don't believe that your parsing code actually supports an
> optional '0x' prefix. In virNodeDevCapAPCardParseXML(), you call
>
> virStrToLong_uip(adapter, NULL, 0, &ap_card->ap_adapter)
>
> But I'm quite sure that passing a value o
On Fri, 13 Nov 2020 12:09:26 +0100
Shalini Chellathurai Saroja wrote:
> Hi Jonathon,
>
> Thank you for the quick review:-)
>
> On 11/12/20 5:27 PM, Jonathon Jongsma wrote:
> >> +
> >> +
> >> +
> >> +
> >> +
> >> + >> name='hexuint'/>
> > It seems that you're unne
Hi Jonathon,
Thank you for the quick review:-)
On 11/12/20 5:27 PM, Jonathon Jongsma wrote:
+
+
+
+
+
+
It seems that you're unnecessarily changing double-quotes to
single-quotes here, which adds spurious changes to the diff. The rest of
the file uses double-quote
On Thu, 12 Nov 2020 13:15:09 +0100
Shalini Chellathurai Saroja wrote:
> Introduce support for the Adjunct Processor (AP) crypto card device.
> Udev already detects the device, so add support for libvirt nodedev
> driver.
>
> Signed-off-by: Farhan Ali
> Signed-off-by: Shalini Chellathurai Saroja
Introduce support for the Adjunct Processor (AP) crypto card device.
Udev already detects the device, so add support for libvirt nodedev
driver.
Signed-off-by: Farhan Ali
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
docs/formatnode.html
