Hello,
This patch is generating errors when booting Libvirt in a Power 8 host:
2020-06-26 21:35:49.703+: 139213: error : virDomainDeviceInfoFormat:7527 :
internal error: Missing uid or fid attribute of zPCI address
2020-06-26 21:35:49.703+: 139213: error :
On Fri, 2020-06-26 at 16:08 +0200, Bjoern Walk wrote:
> Andrea Bolognani [2020-06-25, 07:43PM +0200]:
> > static int
> > virDomainZPCIAddressReserveId(virHashTablePtr set,
> > - unsigned int id,
> > + virZPCIDeviceAddressID *id,
> >
Andrea Bolognani [2020-06-25, 07:43PM +0200]:
> From 82197ea6d794144e51b72f97df2315a65134b385 Mon Sep 17 00:00:00 2001
> From: Andrea Bolognani
> Date: Thu, 25 Jun 2020 18:37:27 +0200
> Subject: [libvirt PATCH 1/2] conf: Move id->{value,isSet} handling further
> down the stack
>
>
On 6/25/20 7:43 PM, Andrea Bolognani wrote:
First of all, this is much closer to what I had in mind. Good job!
Hi Andrea,
Thank you:-)
We're not quite there yet, though: as you can see from the hunks
above, there are still many scenarios in which we're either
manipulating id->value and
On 6/25/20 7:43 PM, Andrea Bolognani wrote:
On Thu, 2020-06-18 at 10:25 +0200, Shalini Chellathurai Saroja wrote:
@@ -129,7 +129,8 @@ static void
virDomainZPCIAddressReleaseUid(virHashTablePtr set,
virZPCIDeviceAddressPtr addr)
{
-
On Thu, 2020-06-18 at 10:25 +0200, Shalini Chellathurai Saroja wrote:
> @@ -129,7 +129,8 @@ static void
> virDomainZPCIAddressReleaseUid(virHashTablePtr set,
> virZPCIDeviceAddressPtr addr)
> {
> -virDomainZPCIAddressReleaseId(set, >uid, "uid");
> +if
Let us fix the issues with zPCI address validation and auto-generation
on s390.
Currently, there are two issues with handling the ZPCI address
extension. Firstly, when the uid is to be auto-generated with a
specified fid, .i.e.:
...
...
we expect uid='0x0001' (or the
