Re: [PATCH libvirt v4 09/12] node_device: refactor address retrieval of node device

2020-12-10 Thread Boris Fiuczynski
On 12/10/20 1:01 PM, John Ferlan wrote: Coverity got pretty grumpy this morning with RESOURCE_LEAKS due to override of @addr as changing from a break; inside a switch/case statement sent us back to the for statement rather than outside the loop which would occur on the break; inside the if {}

Re: [PATCH libvirt v4 09/12] node_device: refactor address retrieval of node device

2020-12-10 Thread John Ferlan
On 12/3/20 12:59 PM, Shalini Chellathurai Saroja wrote: > Use switch statements instead of if-else condition in the method > nodeDeviceFindAddressByName to retrieve address of a node device. > > Signed-off-by: Shalini Chellathurai Saroja > Reviewed-by: Bjoern Walk > Reviewed-by: Boris

[PATCH libvirt v4 09/12] node_device: refactor address retrieval of node device

2020-12-03 Thread Shalini Chellathurai Saroja
Use switch statements instead of if-else condition in the method nodeDeviceFindAddressByName to retrieve address of a node device. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski --- src/node_device/node_device_driver.c | 30