Re: [PATCH v2] qemuDomainSaveInternal: fix memoryleak of virDomainDef

2020-07-30 Thread Michal Privoznik
On 7/29/20 9:51 PM, Laine Stump wrote: I thought about not pushing this until after the freeze is over and 6.7.0 is released (since it is a bug, but a bug that's been in the code for 9 years), but in the end decided to push it, because 1) it's a bonafide leak in theĀ  *non*-error path of a

RE: [PATCH v2] qemuDomainSaveInternal: fix memoryleak of virDomainDef

2020-07-29 Thread zhengchuan
; yubihong Subject: Re: [PATCH v2] qemuDomainSaveInternal: fix memoryleak of virDomainDef On 7/28/20 11:42 PM, Chuan Zheng wrote: > From: Zheng Chuan > > virDomainDefPtr 'def' is forgot to free after qemuDomainDefFormatLive(), fix > it. > > Signed-off-by: Zheng Chuan

Re: [PATCH v2] qemuDomainSaveInternal: fix memoryleak of virDomainDef

2020-07-29 Thread Laine Stump
On 7/28/20 11:42 PM, Chuan Zheng wrote: From: Zheng Chuan virDomainDefPtr 'def' is forgot to free after qemuDomainDefFormatLive(), fix it. Signed-off-by: Zheng Chuan --- src/qemu/qemu_driver.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH v2] qemuDomainSaveInternal: fix memoryleak of virDomainDef

2020-07-28 Thread Chuan Zheng
From: Zheng Chuan virDomainDefPtr 'def' is forgot to free after qemuDomainDefFormatLive(), fix it. Signed-off-by: Zheng Chuan --- src/qemu/qemu_driver.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index