Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-06-01 Thread Jason Gunthorpe
On Wed, May 31, 2023 at 03:34:11PM -0600, Alex Williamson wrote: > device. It does not guarantee the vfio device API exposed to userspace > is vfio-pci. Therefore management tools should be cautious to make > assumptions about the type of device the VM will see even though we've > got vfio-pci

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Alex Williamson
On Wed, 31 May 2023 17:46:50 -0300 Jason Gunthorpe wrote: > On Wed, May 31, 2023 at 02:40:01PM -0600, Alex Williamson wrote: > > > Also note that we're saying "vfio" not "vfio-pci". Only the mdev > > interface has the device_api attribute to indicate the exported vfio > > device interface.

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Jason Gunthorpe
On Wed, May 31, 2023 at 02:40:01PM -0600, Alex Williamson wrote: > Also note that we're saying "vfio" not "vfio-pci". Only the mdev > interface has the device_api attribute to indicate the exported vfio > device interface. The "vfio_pci:" match in modalias indicates a vfio > PCI driver, not

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Alex Williamson
On Wed, 31 May 2023 14:30:52 -0300 Jason Gunthorpe wrote: > On Wed, May 31, 2023 at 01:18:44PM -0400, Laine Stump wrote: > > On 5/31/23 10:31 AM, Jason Gunthorpe wrote: > > > On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: > > > > Hey Laine, > > > > > > > > On 23/08/2022

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Jason Gunthorpe
On Wed, May 31, 2023 at 01:18:44PM -0400, Laine Stump wrote: > On 5/31/23 10:31 AM, Jason Gunthorpe wrote: > > On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: > > > Hey Laine, > > > > > > On 23/08/2022 15:11, Laine Stump wrote: > > > > ping. > > > > > > > > I have a different

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Laine Stump
On 5/31/23 10:31 AM, Jason Gunthorpe wrote: On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: Hey Laine, On 23/08/2022 15:11, Laine Stump wrote: ping. I have a different version of this patch where I do read the modules.alias file rather than just checking the name of the driver,

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Joao Martins
On 31/05/2023 15:31, Jason Gunthorpe wrote: > On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: >> Hey Laine, >> >> On 23/08/2022 15:11, Laine Stump wrote: >>> ping. >>> >>> I have a different version of this patch where I do read the modules.alias >>> file >>> rather than just

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Joao Martins
Hey Laine, On 23/08/2022 15:11, Laine Stump wrote: > ping. > > I have a different version of this patch where I do read the modules.alias > file > rather than just checking the name of the driver, but that also requires > "double > mocking" open() in the unit test, which wasn't working

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Jason Gunthorpe
On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: > Hey Laine, > > On 23/08/2022 15:11, Laine Stump wrote: > > ping. > > > > I have a different version of this patch where I do read the modules.alias > > file > > rather than just checking the name of the driver, but that also

Re: [PATCH v2] util: basic support for VFIO variant drivers

2022-08-23 Thread Alex Williamson
On Tue, 23 Aug 2022 10:11:32 -0400 Laine Stump wrote: > ping. > > I have a different version of this patch where I do read the > modules.alias file rather than just checking the name of the driver, but > that also requires "double mocking" open() in the unit test, which > wasn't working

Re: [PATCH v2] util: basic support for VFIO variant drivers

2022-08-23 Thread Michal Prívozník
On 8/23/22 16:11, Laine Stump wrote: > ping. > > I have a different version of this patch where I do read the > modules.alias file rather than just checking the name of the driver, but > that also requires "double mocking" open() in the unit test, which > wasn't working properly, and I'd rather

Re: [PATCH v2] util: basic support for VFIO variant drivers

2022-08-23 Thread Laine Stump
ping. I have a different version of this patch where I do read the modules.alias file rather than just checking the name of the driver, but that also requires "double mocking" open() in the unit test, which wasn't working properly, and I'd rather not spend the time figuring it out if it's

[PATCH v2] util: basic support for VFIO variant drivers

2022-08-10 Thread Laine Stump
Before a PCI device can be assigned to a guest with VFIO, that device must be bound to the vfio-pci driver rather than to the device's normal driver. The vfio-pci driver provides APIs that permit QEMU to perform all the necessary operations to make the device accessible to the guest. There has