Re: [PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

2020-10-06 Thread Matt Coleman
> On Oct 6, 2020, at 4:21 AM, Daniel P. Berrangé wrote: > > On Mon, Oct 05, 2020 at 09:13:29PM -0400, Matt Coleman wrote: >>> On Oct 5, 2020, at 8:54 PM, Neal Gompa wrote: >>> >>> Should we require a bump to openwsman 2.6 for this? >> >> That won’t make any difference: openwsman 2.6+ supports

Re: [PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

2020-10-06 Thread Daniel P . Berrangé
On Mon, Oct 05, 2020 at 09:13:29PM -0400, Matt Coleman wrote: > > On Oct 5, 2020, at 8:54 PM, Neal Gompa wrote: > > > > Should we require a bump to openwsman 2.6 for this? > > That won’t make any difference: openwsman 2.6+ supports specifying the > locale, but Windows ignores it. So, this

Re: [PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

2020-10-05 Thread Matt Coleman
> On Oct 5, 2020, at 8:54 PM, Neal Gompa wrote: > > Should we require a bump to openwsman 2.6 for this? That won’t make any difference: openwsman 2.6+ supports specifying the locale, but Windows ignores it. So, this patch changes the queries to not use localized strings. -- Matt

Re: [PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

2020-10-05 Thread Neal Gompa
On Mon, Oct 5, 2020 at 9:13 PM Matt Coleman wrote: > > > On Oct 5, 2020, at 8:54 PM, Neal Gompa wrote: > > > > Should we require a bump to openwsman 2.6 for this? > > That won’t make any difference: openwsman 2.6+ supports specifying the > locale, but Windows ignores it. So, this patch changes

Re: [PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

2020-10-05 Thread Neal Gompa
On Mon, Oct 5, 2020 at 12:21 PM Matt Coleman wrote: > > There are two specific WQL queries we're using to get either a list of > virtual machines or the hypervisor host itself from Msvm_ComputerSystem. > Those queries rely on filtering results based on the "Description" > field. Since the

[PATCH v2 01/10] hyperv: make Msvm_ComputerSystem WQL queries locale agnostic

2020-10-05 Thread Matt Coleman
There are two specific WQL queries we're using to get either a list of virtual machines or the hypervisor host itself from Msvm_ComputerSystem. Those queries rely on filtering results based on the "Description" field. Since the "Description" field is locale sensitive, the queries will fail if the