Re: [PATCH v2 08/10] hyperv: implement connectGetVersion

2020-10-05 Thread Neal Gompa
On Mon, Oct 5, 2020 at 12:22 PM Matt Coleman wrote: > > Hyper-V version numbers are not compatible with the encoding in > virParseVersionString(): > https://gitlab.com/libvirt/libvirt/-/blob/master/src/util/virutil.c#L246 > > For example, the Windows Server 2016 Hyper-V version is 10.0.14393: its

[PATCH v2 08/10] hyperv: implement connectGetVersion

2020-10-05 Thread Matt Coleman
Hyper-V version numbers are not compatible with the encoding in virParseVersionString(): https://gitlab.com/libvirt/libvirt/-/blob/master/src/util/virutil.c#L246 For example, the Windows Server 2016 Hyper-V version is 10.0.14393: its micro is over 14 times larger than the encoding allows. This