Re: [PATCH v2 08/17] virstring: Introduce virStringIsNull()

2020-08-20 Thread Peter Krempa
On Thu, Aug 20, 2020 at 14:36:15 +0200, Michal Privoznik wrote: > On 8/20/20 1:02 PM, Peter Krempa wrote: > > On Tue, Jul 07, 2020 at 21:46:26 +0200, Michal Privoznik wrote: > > > This function will be used to detect zero buffers (which are > > > going to be interpreted as hole in virStream

Re: [PATCH v2 08/17] virstring: Introduce virStringIsNull()

2020-08-20 Thread Michal Privoznik
On 8/20/20 1:02 PM, Peter Krempa wrote: On Tue, Jul 07, 2020 at 21:46:26 +0200, Michal Privoznik wrote: This function will be used to detect zero buffers (which are going to be interpreted as hole in virStream later). I shamelessly took inspiration from coreutils. Coreutils is proudly GPLv3

Re: [PATCH v2 08/17] virstring: Introduce virStringIsNull()

2020-08-20 Thread Peter Krempa
On Thu, Aug 20, 2020 at 13:17:42 +0100, Daniel Berrange wrote: > On Thu, Aug 20, 2020 at 01:02:55PM +0200, Peter Krempa wrote: > > On Tue, Jul 07, 2020 at 21:46:26 +0200, Michal Privoznik wrote: > > > This function will be used to detect zero buffers (which are > > > going to be interpreted as

Re: [PATCH v2 08/17] virstring: Introduce virStringIsNull()

2020-08-20 Thread Daniel P . Berrangé
On Thu, Aug 20, 2020 at 01:02:55PM +0200, Peter Krempa wrote: > On Tue, Jul 07, 2020 at 21:46:26 +0200, Michal Privoznik wrote: > > This function will be used to detect zero buffers (which are > > going to be interpreted as hole in virStream later). > > > > I shamelessly took inspiration from

Re: [PATCH v2 08/17] virstring: Introduce virStringIsNull()

2020-08-20 Thread Peter Krempa
On Tue, Jul 07, 2020 at 21:46:26 +0200, Michal Privoznik wrote: > This function will be used to detect zero buffers (which are > going to be interpreted as hole in virStream later). > > I shamelessly took inspiration from coreutils. Coreutils is proudly GPLv3 ... > Signed-off-by: Michal

[PATCH v2 08/17] virstring: Introduce virStringIsNull()

2020-07-07 Thread Michal Privoznik
This function will be used to detect zero buffers (which are going to be interpreted as hole in virStream later). I shamelessly took inspiration from coreutils. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virstring.c | 38