Re: [PATCH v2 1/6] qemu_process.c: check migrateURI when setting VIR_QEMU_PROCESS_START_NEW

2020-12-03 Thread Andrea Bolognani
On Wed, 2020-11-18 at 16:58 -0300, Daniel Henrique Barboza wrote: > qemuProcessCreatePretendCmdPrepare() is setting the > VIR_QEMU_PROCESS_START_NEW regardless of whether this is > a migration case or not. This behavior differs from what we're > doing in qemuProcessStart(), where the flag is set

Re: [PATCH v2 1/6] qemu_process.c: check migrateURI when setting VIR_QEMU_PROCESS_START_NEW

2020-12-01 Thread Michal Privoznik
On 11/18/20 8:58 PM, Daniel Henrique Barboza wrote: qemuProcessCreatePretendCmdPrepare() is setting the VIR_QEMU_PROCESS_START_NEW regardless of whether this is a migration case or not. This behavior differs from what we're doing in qemuProcessStart(), where the flag is set only if !migrate &&

[PATCH v2 1/6] qemu_process.c: check migrateURI when setting VIR_QEMU_PROCESS_START_NEW

2020-11-18 Thread Daniel Henrique Barboza
qemuProcessCreatePretendCmdPrepare() is setting the VIR_QEMU_PROCESS_START_NEW regardless of whether this is a migration case or not. This behavior differs from what we're doing in qemuProcessStart(), where the flag is set only if !migrate && !snapshot. Fix it by making the flag setting