Re: [PATCH v2 2/7] migration/dirtyrate: Implement qemuMonitorJSONExtractDirtyRateInfo

2020-10-25 Thread Hao Wang
Thanks for the reminding. I would fix that in my V3 patches. 在 2020/10/26 14:24, Peter Krempa 写道: > On Sun, Oct 25, 2020 at 10:35:03 +0800, Hao Wang wrote: >> Hi Daniel, >> >> For the warning in your compiling -- "error: >> ‘qemuMonitorJSONExtractDirtyRateInfo’ defined but not used >> [-Werror=

Re: [PATCH v2 2/7] migration/dirtyrate: Implement qemuMonitorJSONExtractDirtyRateInfo

2020-10-25 Thread Peter Krempa
On Sun, Oct 25, 2020 at 10:35:03 +0800, Hao Wang wrote: > Hi Daniel, > > For the warning in your compiling -- "error: > ‘qemuMonitorJSONExtractDirtyRateInfo’ defined but not used > [-Werror=unused-function]": > > " qemuMonitorJSONExtractDirtyRateInfo" would be called by function > "qemuMonitor

Re: [PATCH v2 2/7] migration/dirtyrate: Implement qemuMonitorJSONExtractDirtyRateInfo

2020-10-24 Thread Hao Wang
Hi Daniel, For the warning in your compiling -- "error: ‘qemuMonitorJSONExtractDirtyRateInfo’ defined but not used [-Werror=unused-function]": " qemuMonitorJSONExtractDirtyRateInfo" would be called by function "qemuMonitorJSONQueryDirtyRate" in [PATCH 3/7]. So please apply all the serial of pa

Re: [PATCH v2 2/7] migration/dirtyrate: Implement qemuMonitorJSONExtractDirtyRateInfo

2020-10-23 Thread Daniel Henrique Barboza
On 10/19/20 9:58 AM, Hao Wang wrote: Implement qemuMonitorJSONExtractDirtyRateInfo to deal with the return from qmp "query-dirty-rate", and store them in virDomainDirtyRateInfo. Signed-off-by: Hao Wang Reviewed-by: Chuan Zheng --- This patch failed to compile in my env: ../src/qemu/qe

[PATCH v2 2/7] migration/dirtyrate: Implement qemuMonitorJSONExtractDirtyRateInfo

2020-10-19 Thread Hao Wang
Implement qemuMonitorJSONExtractDirtyRateInfo to deal with the return from qmp "query-dirty-rate", and store them in virDomainDirtyRateInfo. Signed-off-by: Hao Wang Reviewed-by: Chuan Zheng --- include/libvirt/libvirt-domain.h | 16 +++ src/qemu/qemu_monitor_json.c | 48