Re: [PATCH v3] interface: fix udev_device_get_sysattr_value return value check

2023-09-25 Thread Martin Kletzander
On Tue, Sep 12, 2023 at 03:56:47PM +0300, Dmitry Frolov wrote: Reviewing the code I found that return value of function udev_device_get_sysattr_value() is dereferenced without a check. udev_device_get_sysattr_value() may return NULL by number of reasons. v2: VIR_DEBUG added, replaced

[PATCH v3] interface: fix udev_device_get_sysattr_value return value check

2023-09-12 Thread Dmitry Frolov
Reviewing the code I found that return value of function udev_device_get_sysattr_value() is dereferenced without a check. udev_device_get_sysattr_value() may return NULL by number of reasons. v2: VIR_DEBUG added, replaced STREQ(NULLSTR()) with STREQ_NULLABLE() v3: More checks added, to skip