Re: [PATCH v3 1/4] src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1

2021-01-07 Thread Nikolay Shirokovskiy
Sigh.. One more issue with the patch series. I sent a tiny patch for formal approval. Nikolay On Thu, Jan 7, 2021 at 3:00 PM Michal Privoznik wrote: > On 1/7/21 12:53 PM, John Ferlan wrote: > > > > > > On 12/18/20 1:56 AM, Nikolay Shirokovskiy wrote: > >> Otherwise in some places we can

Re: [PATCH v3 1/4] src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1

2021-01-07 Thread Michal Privoznik
On 1/7/21 12:53 PM, John Ferlan wrote: On 12/18/20 1:56 AM, Nikolay Shirokovskiy wrote: Otherwise in some places we can mistakenly report 'unsupported' error instead of root cause. So let's handle root cause explicitly from the macro. Signed-off-by: Nikolay Shirokovskiy ---

Re: [PATCH v3 1/4] src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1

2021-01-07 Thread John Ferlan
On 12/18/20 1:56 AM, Nikolay Shirokovskiy wrote: > Otherwise in some places we can mistakenly report 'unsupported' error instead > of root cause. So let's handle root cause explicitly from the macro. > > Signed-off-by: Nikolay Shirokovskiy > --- > src/libvirt-domain.c | 511 >

Re: [PATCH v3 1/4] src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1

2021-01-06 Thread Daniel P . Berrangé
On Fri, Dec 18, 2020 at 09:56:45AM +0300, Nikolay Shirokovskiy wrote: > Otherwise in some places we can mistakenly report 'unsupported' error instead > of root cause. So let's handle root cause explicitly from the macro. > > Signed-off-by: Nikolay Shirokovskiy > --- > src/libvirt-domain.c | 511

[PATCH v3 1/4] src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1

2020-12-18 Thread Nikolay Shirokovskiy
Otherwise in some places we can mistakenly report 'unsupported' error instead of root cause. So let's handle root cause explicitly from the macro. Signed-off-by: Nikolay Shirokovskiy --- src/libvirt-domain.c | 511 ++- src/libvirt-host.c | 18