Re: [PATCHv3 3/3] lxc: fix a memory leak

2021-01-06 Thread Laine Stump
On 12/18/20 10:45 PM, Shi Lei wrote: On 2020-12-18 at 22:01, John Ferlan wrote: Coverity reminds us of the ancient software engineering proverb related to being stuck with ownership because you touched the code last :-) - I know this patch didn't cause the problem, but because the code was

Re: Re: [PATCHv3 3/3] lxc: fix a memory leak

2020-12-18 Thread Shi Lei
On 2020-12-18 at 22:01, John Ferlan wrote: > >Coverity reminds us of the ancient software engineering proverb related >to being stuck with ownership because you touched the code last :-) - I >know this patch didn't cause the problem, but because the code was >touched Coverity decided to look

Re: [PATCHv3 3/3] lxc: fix a memory leak

2020-12-18 Thread John Ferlan
Coverity reminds us of the ancient software engineering proverb related to being stuck with ownership because you touched the code last :-) - I know this patch didn't cause the problem, but because the code was touched Coverity decided to look harder and found another leak. On 12/16/20 1:01 AM,

[PATCHv3 3/3] lxc: fix a memory leak

2020-12-15 Thread Shi Lei
In virLXCProcessSetupInterfaceTap, containerVeth needs to be freed on failure. Signed-off-by: Shi Lei --- src/lxc/lxc_process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 85d0287a..0f7c9295 100644 ---