Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-04 Thread Divya Garg
On 04/01/22 7:27 pm, Daniel P. Berrangé wrote: On Tue, Jan 04, 2022 at 11:47:39AM +, John Levon wrote: On Sat, Dec 11, 2021 at 07:57:47PM -0800, “Divya wrote: From: Divya Garg VM XML accepts target.port but this does not get passed while building the qemu command line for this VM.

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-04 Thread Daniel P . Berrangé
On Tue, Jan 04, 2022 at 11:47:39AM +, John Levon wrote: > On Sat, Dec 11, 2021 at 07:57:47PM -0800, “Divya wrote: > > > From: Divya Garg > > > > VM XML accepts target.port but this does not get passed while building the > > qemu > > command line for this VM. > > Apologies, I failed to

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-04 Thread Divya Garg
On 04/01/22 5:56 pm, Ani Sinha wrote: On Tue, 4 Jan 2022, Divya Garg wrote: On 04/01/22 5:47 pm, Ani Sinha wrote: On Mon, 3 Jan 2022, Divya Garg wrote: Thankyou Ani for the review. I will be taking up the comments in next patchset along with other comments. On 03/01/22 1:44 pm, Ani

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-04 Thread Ani Sinha
On Tue, 4 Jan 2022, Divya Garg wrote: > On 04/01/22 5:47 pm, Ani Sinha wrote: > > > > On Mon, 3 Jan 2022, Divya Garg wrote: > > > > > Thankyou Ani for the review. I will be taking up the comments > > > in next patchset along with other comments. > > > > > > On 03/01/22 1:44 pm, Ani Sinha

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-04 Thread Divya Garg
On 04/01/22 5:47 pm, Ani Sinha wrote: On Mon, 3 Jan 2022, Divya Garg wrote: Thankyou Ani for the review. I will be taking up the comments in next patchset along with other comments. On 03/01/22 1:44 pm, Ani Sinha wrote: On Mon, 3 Jan 2022, Divya Garg wrote: Hi all ! Looking forward for

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-04 Thread Divya Garg
On 04/01/22 5:17 pm, John Levon wrote: On Sat, Dec 11, 2021 at 07:57:47PM -0800, “Divya wrote: From: Divya Garg VM XML accepts target.port but this does not get passed while building the qemu command line for this VM. Apologies, I failed to notice this had been sent out to the list;

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-04 Thread John Levon
On Sat, Dec 11, 2021 at 07:57:47PM -0800, “Divya wrote: > From: Divya Garg > > VM XML accepts target.port but this does not get passed while building the > qemu > command line for this VM. Apologies, I failed to notice this had been sent out to the list; Re-posting my comments from an

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-04 Thread Ani Sinha
On Mon, 3 Jan 2022, Divya Garg wrote: > Thankyou Ani for the review. I will be taking up the comments > in next patchset along with other comments. > > On 03/01/22 1:44 pm, Ani Sinha wrote: > > > > > On Mon, 3 Jan 2022, Divya Garg wrote: > > > > > Hi all ! > > > > > > Looking forward for the

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-03 Thread Ani Sinha
On Mon, 3 Jan 2022, Divya Garg wrote: > Thankyou Ani for the review. I will be taking up the comments > in next patchset along with other comments. > > On 03/01/22 1:44 pm, Ani Sinha wrote: > > > > > On Mon, 3 Jan 2022, Divya Garg wrote: > > > > > Hi all ! > > > > > > Looking forward for the

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-03 Thread Divya Garg
Thankyou Ani for the review. I will be taking up the comments in next patchset along with other comments. On 03/01/22 1:44 pm, Ani Sinha wrote: On Mon, 3 Jan 2022, Divya Garg wrote: Hi all ! Looking forward for the review comments on the patch. For single patches, no need to use

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-03 Thread Ani Sinha
On Mon, 3 Jan 2022, Divya Garg wrote: > Hi all ! > > Looking forward for the review comments on the patch. > For single patches, no need to use numbering. > Thanks > Regards > Divya Garg > > > On 12/12/21 9:27 am, “Divya wrote: > > From: Divya Garg > > > > VM XML accepts target.port but this

Re: [RFC v2 1/1] qemu: add index for isa-serial device using target.port

2022-01-02 Thread Divya Garg
Hi all ! Looking forward for the review comments on the patch. Thanks Regards Divya Garg On 12/12/21 9:27 am, “Divya wrote: From: Divya Garg VM XML accepts target.port but this does not get passed while building the qemu command line for this VM. This patch fixes this bug. In addition,

[RFC v2 1/1] qemu: add index for isa-serial device using target.port

2021-12-11 Thread “Divya
From: Divya Garg VM XML accepts target.port but this does not get passed while building the qemu command line for this VM. This patch fixes this bug. In addition, this introduces additional checks in the port allocation logic for isa-serial devices to : * Check availability of requested ports *