Re: [libvirt] "[V3] RFC for support cache tune in libvirt"

2017-01-12 Thread Marcelo Tosatti
On Thu, Jan 12, 2017 at 11:06:06AM +, Daniel P. Berrange wrote: > On Thu, Jan 12, 2017 at 08:48:01AM -0200, Marcelo Tosatti wrote: > > On Thu, Jan 12, 2017 at 09:44:36AM +0800, 乔立勇(Eli Qiao) wrote: > > > hi, It's really good to have you get involved to support CAT in > > > libvirt/OpenStack. >

Re: [libvirt] "[V3] RFC for support cache tune in libvirt"

2017-01-12 Thread Daniel P. Berrange
On Thu, Jan 12, 2017 at 08:48:01AM -0200, Marcelo Tosatti wrote: > On Thu, Jan 12, 2017 at 09:44:36AM +0800, 乔立勇(Eli Qiao) wrote: > > hi, It's really good to have you get involved to support CAT in > > libvirt/OpenStack. > > replied inlines. > > > > 2017-01-11 20:19 GMT+08:00 Marcelo Tosatti

Re: [libvirt] "[V3] RFC for support cache tune in libvirt"

2017-01-12 Thread Marcelo Tosatti
On Thu, Jan 12, 2017 at 09:44:36AM +0800, 乔立勇(Eli Qiao) wrote: > hi, It's really good to have you get involved to support CAT in > libvirt/OpenStack. > replied inlines. > > 2017-01-11 20:19 GMT+08:00 Marcelo Tosatti : > > > > > Hi, > > > > Comments/questions related to: > >

Re: [libvirt] "[V3] RFC for support cache tune in libvirt"

2017-01-12 Thread Marcelo Tosatti
On Thu, Jan 12, 2017 at 08:47:58AM -0200, Marcelo Tosatti wrote: > On Thu, Jan 12, 2017 at 09:44:36AM +0800, 乔立勇(Eli Qiao) wrote: > > hi, It's really good to have you get involved to support CAT in > > libvirt/OpenStack. > > replied inlines. > > > > 2017-01-11 20:19 GMT+08:00 Marcelo Tosatti

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-12 Thread Martin Kletzander
On Thu, Jan 12, 2017 at 09:20:30AM +, Daniel P. Berrange wrote: On Thu, Jan 12, 2017 at 11:15:39AM +0800, 乔立勇(Eli Qiao) wrote: > > > > > > yes, I like this too, it could tell the the resource sharing logic by cpus. Another thinking is that if kernel enable CDP, it will

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-12 Thread Daniel P. Berrange
On Thu, Jan 12, 2017 at 11:15:39AM +0800, 乔立勇(Eli Qiao) wrote: > > > > > > > > > > > > > > yes, I like this too, it could tell the the resource sharing logic by cpus. > > Another thinking is that if kernel enable CDP, it will split l3 cache to > code / data type > >

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-12 Thread Daniel P. Berrange
On Thu, Jan 12, 2017 at 10:58:53AM +0800, 乔立勇(Eli Qiao) wrote: > 2017-01-11 19:09 GMT+08:00 Daniel P. Berrange : > > > On Wed, Jan 11, 2017 at 11:55:28AM +0100, Martin Kletzander wrote: > > > On Wed, Jan 11, 2017 at 10:05:26AM +, Daniel P. Berrange wrote: > > > > > > > >

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-11 Thread Martin Kletzander
On Thu, Jan 12, 2017 at 10:58:53AM +0800, 乔立勇(Eli Qiao) wrote: 2017-01-11 19:09 GMT+08:00 Daniel P. Berrange : On Wed, Jan 11, 2017 at 11:55:28AM +0100, Martin Kletzander wrote: > On Wed, Jan 11, 2017 at 10:05:26AM +, Daniel P. Berrange wrote: > > > > IIUC, the kernel

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-11 Thread Martin Kletzander
On Thu, Jan 12, 2017 at 11:19:07AM +0800, 乔立勇(Eli Qiao) wrote: more like this: If so, we need to extend "virsh cputune" or and new API like cachetune? Yeah, sure, that's a detail to be done after the design is done. Regards,

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-11 Thread Eli Qiao
> > more like this: > > > > > > If so, we need to extend "virsh cputune" or and new API like cachetune? > > > > > > > > Regards, > Daniel > -- > |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ > :| > |:

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-11 Thread Eli Qiao
> > > > which shows each socket has its own dedicated L3 cache, and each > > core has its own L2 & L1 cache. > > We need to also include the host cache ID value in the XML to > let us reliably distinguish / associate with differet cache > banks when placing guests, if there's multiple caches of

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-11 Thread Eli Qiao
> > > > > > yes, I like this too, it could tell the the resource sharing logic by cpus. Another thinking is that if kernel enable CDP, it will split l3 cache to code / data type So these information should not only from

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-11 Thread Eli Qiao
2017-01-11 19:09 GMT+08:00 Daniel P. Berrange : > On Wed, Jan 11, 2017 at 11:55:28AM +0100, Martin Kletzander wrote: > > On Wed, Jan 11, 2017 at 10:05:26AM +, Daniel P. Berrange wrote: > > > > > > IIUC, the kernel lets us associate individual PIDs > > > with each cache.

Re: [libvirt] "[V3] RFC for support cache tune in libvirt"

2017-01-11 Thread Eli Qiao
hi, It's really good to have you get involved to support CAT in libvirt/OpenStack. replied inlines. 2017-01-11 20:19 GMT+08:00 Marcelo Tosatti : > > Hi, > > Comments/questions related to: > https://www.redhat.com/archives/libvir-list/2017-January/msg00354.html > > 1) root

Re: [libvirt] "[V3] RFC for support cache tune in libvirt"

2017-01-11 Thread Marcelo Tosatti
On Wed, Jan 11, 2017 at 10:34:00AM -0200, Marcelo Tosatti wrote: > On Wed, Jan 11, 2017 at 10:19:10AM -0200, Marcelo Tosatti wrote: > > > > Hi, > > > > Comments/questions related to: > > https://www.redhat.com/archives/libvir-list/2017-January/msg00354.html > > > > 1) root s2600wt:~/linux#

Re: [libvirt] "[V3] RFC for support cache tune in libvirt"

2017-01-11 Thread Marcelo Tosatti
On Wed, Jan 11, 2017 at 10:19:10AM -0200, Marcelo Tosatti wrote: > > Hi, > > Comments/questions related to: > https://www.redhat.com/archives/libvir-list/2017-January/msg00354.html > > 1) root s2600wt:~/linux# virsh cachetune kvm02 --l3.count 2 > > How does allocation of code/data look like? >

Re: [libvirt] "[V3] RFC for support cache tune in libvirt"

2017-01-11 Thread Marcelo Tosatti
Hi, Comments/questions related to: https://www.redhat.com/archives/libvir-list/2017-January/msg00354.html 1) root s2600wt:~/linux# virsh cachetune kvm02 --l3.count 2 How does allocation of code/data look like? 2) 'nodecachestats' command: 3. Add new virsh command 'nodecachestats':

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-11 Thread Daniel P. Berrange
On Wed, Jan 11, 2017 at 10:05:26AM +, Daniel P. Berrange wrote: > On Tue, Jan 10, 2017 at 07:42:59AM +, Qiao, Liyong wrote: > > Add support for cache allocation. > > > > Thanks Martin for the previous version comments, this is the v3 version for > > RFC , I’v have some PoC code [2]. The

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-11 Thread Daniel P. Berrange
On Wed, Jan 11, 2017 at 11:55:28AM +0100, Martin Kletzander wrote: > On Wed, Jan 11, 2017 at 10:05:26AM +, Daniel P. Berrange wrote: > > > > IIUC, the kernel lets us associate individual PIDs > > with each cache. Since each vCPU is a PID, this means > > we are able to allocate different cache

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-11 Thread Martin Kletzander
On Wed, Jan 11, 2017 at 10:05:26AM +, Daniel P. Berrange wrote: On Tue, Jan 10, 2017 at 07:42:59AM +, Qiao, Liyong wrote: Add support for cache allocation. Thanks Martin for the previous version comments, this is the v3 version for RFC , I’v have some PoC code [2]. The follow changes

Re: [libvirt] [V3] RFC for support cache tune in libvirt

2017-01-11 Thread Daniel P. Berrange
On Tue, Jan 10, 2017 at 07:42:59AM +, Qiao, Liyong wrote: > Add support for cache allocation. > > Thanks Martin for the previous version comments, this is the v3 version for > RFC , I’v have some PoC code [2]. The follow changes are partly finished by > the PoC. > > #Propose Changes > >

[libvirt] [V3] RFC for support cache tune in libvirt

2017-01-09 Thread Qiao, Liyong
Add support for cache allocation. Thanks Martin for the previous version comments, this is the v3 version for RFC , I’v have some PoC code [2]. The follow changes are partly finished by the PoC. #Propose Changes ## virsh command line 1. Extend output of nodeinfo, to expose L3 cache size for