Re: [libvirt] [BUG?] EAGAIN not triggering error and 'events' gets cleared

2015-04-28 Thread Peter Krempa
On Tue, Apr 28, 2015 at 11:24:37 +0200, Michal Privoznik wrote: On 28.04.2015 11:06, Pavel Boldin wrote: Well, actually that seems to be quite a different bug in there. I will start a new thread. In short: migration seems to be broken by commit

Re: [libvirt] [BUG?] EAGAIN not triggering error and 'events' gets cleared

2015-04-28 Thread Pavel Boldin
Well, actually that seems to be quite a different bug in there. I will start a new thread. In short: migration seems to be broken by commit 1a92c719101e5bfa6fe2b78006ad04c7f075ea28. This is because introduced job _MODIFY waits while MIGRATION_OUT is finished to change `mirrorState' variable.

Re: [libvirt] [BUG?] EAGAIN not triggering error and 'events' gets cleared

2015-04-28 Thread Michal Privoznik
On 28.04.2015 11:06, Pavel Boldin wrote: Well, actually that seems to be quite a different bug in there. I will start a new thread. In short: migration seems to be broken by commit 1a92c719101e5bfa6fe2b78006ad04c7f075ea28. This is because introduced job _MODIFY waits while MIGRATION_OUT

Re: [libvirt] [BUG?] EAGAIN not triggering error and 'events' gets cleared

2015-04-28 Thread Pavel Boldin
Thanks Peter, It looks good but I did no deep introspection of the code. Should I rebase my patch [1] on that? I can test your code as well then. [1] https://github.com/paboldin/libvirt/commits/master Pavel On Tue, Apr 28, 2015 at 4:42 PM, Peter Krempa pkre...@redhat.com wrote: On Tue, Apr

[libvirt] [BUG?] EAGAIN not triggering error and 'events' gets cleared

2015-04-27 Thread Pavel Boldin
Dear Libvirt Developers, There seems to be a bug or at least a bad behavior in `src/qemu/qemu_monitor.c' lines 683-689 function `qemuMonitorIO': if (qemuMonitorIOWrite(mon) 0) { error = true; if (errno == ECONNRESET) hangup = true;