Re: [libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser

2016-10-11 Thread Ian Jackson
Julien Grall writes ("Re: [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser"): > live migration is not currently the supported but will be in the future. > FWIW, there is a patch series on xen-devel to support dead migration > (first step for live migration) [1].

Re: [libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser

2016-10-11 Thread Julien Grall
Hi Ian, On 06/10/16 11:00, Ian Jackson wrote: Julien Grall writes ("Re: [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser"): On 04/10/2016 10:05, Ian Jackson wrote: Missing _. I didn't test this again before sending it. I'd still like a review from libvirt

Re: [libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser

2016-10-06 Thread Ian Jackson
Julien Grall writes ("Re: [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser"): > On 04/10/2016 10:05, Ian Jackson wrote: > > Missing _. I didn't test this again before sending it. I'd still > > like a review from libvirt (and Xen/ARM) folks. > > I am not sure

Re: [libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser

2016-10-05 Thread Jim Fehlig
On 10/04/2016 11:02 AM, Ian Jackson wrote: Do not grep the virsh capabilities output (!) Instead, parse the XML using perl's XML modules and look for the specific feature flag using an XPATH pattern. AFAICT from looking at the XML, that's But the original code

Re: [libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser

2016-10-05 Thread Julien Grall
Hi Ian, On 04/10/2016 10:05, Ian Jackson wrote: Ian Jackson writes ("[OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser"): Do not grep the virsh capabilities output (!) Instead, parse the XML using perl's XML modules and look for the specific feature flag using

Re: [libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser

2016-10-04 Thread Ian Jackson
Ian Jackson writes ("[OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser"): > Do not grep the virsh capabilities output (!) Instead, parse the XML > using perl's XML modules and look for the specific feature flag using > an XPATH pattern. ...> > +sub

[libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser

2016-10-04 Thread Ian Jackson
Do not grep the virsh capabilities output (!) Instead, parse the XML using perl's XML modules and look for the specific feature flag using an XPATH pattern. AFAICT from looking at the XML, that's But the original code does not test for . Xen could in principle