Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-29 Thread Daniel Veillard
On Thu, Oct 23, 2008 at 06:25:37PM +0200, Guido Günther wrote: > Hi Daniel, > On Tue, Oct 21, 2008 at 03:25:25PM +0200, Daniel Veillard wrote: > [..snip..] > > Those are just stylistic issues, I can apply the patch with those > > changed if you wish if you don't have time for a new patch, > Th

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-23 Thread Guido Günther
Hi Daniel, On Tue, Oct 21, 2008 at 03:25:25PM +0200, Daniel Veillard wrote: [..snip..] > Those are just stylistic issues, I can apply the patch with those > changed if you wish if you don't have time for a new patch, Thanks for your comments. Updated version attached. I basically removed the u

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-21 Thread Guido Günther
On Tue, Oct 21, 2008 at 02:42:40PM +0100, Daniel P. Berrange wrote: [..snip..] > Is there not some 'info pci' or 'info disk' command we cna use to find > out the PCI slot number at the time we want to detach the device. This > would make it work for all disks, and avoid the need to track the > st

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-21 Thread Guido Günther
Hi Daniel, On Tue, Oct 21, 2008 at 03:25:25PM +0200, Daniel Veillard wrote: > Those are just stylistic issues, I can apply the patch with those > changed if you wish if you don't have time for a new patch, I'll come up with a corrected version, no problem. -- Guido -- Libvir-list mailing list

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-21 Thread Daniel P. Berrange
On Fri, Oct 17, 2008 at 04:24:52PM +0200, Guido G?nther wrote: > On Fri, Oct 17, 2008 at 02:37:17PM +0200, Daniel Veillard wrote: > [..snip..] > > Looks fine, i just removed a couple of extra spaces at end of line > > before commiting :-) > Thanks a lot for applying this so quickly! Attached is

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-21 Thread Daniel Veillard
On Fri, Oct 17, 2008 at 04:24:52PM +0200, Guido Günther wrote: > On Fri, Oct 17, 2008 at 02:37:17PM +0200, Daniel Veillard wrote: > [..snip..] > > Looks fine, i just removed a couple of extra spaces at end of line > > before commiting :-) > Thanks a lot for applying this so quickly! Attached is

[libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-17 Thread Guido Günther
On Fri, Oct 17, 2008 at 02:37:17PM +0200, Daniel Veillard wrote: [..snip..] > Looks fine, i just removed a couple of extra spaces at end of line > before commiting :-) Thanks a lot for applying this so quickly! Attached is a patch that allows for unplugging of disks. To do that I added a token t