Re: [libvirt] [PATCH]: hostdev passthrough support take #4

2008-08-12 Thread Daniel Veillard
On Fri, Aug 08, 2008 at 05:59:56PM +0200, Guido Günther wrote: Hi, On Fri, Aug 08, 2008 at 10:34:00AM -0400, Daniel Veillard wrote: [..snip..] I think the only thing missing is extending the descrition in the documentation would you mind adding a description in formatdomain.html(.in)

[libvirt] [PATCH]: hostdev passthrough support take #4

2008-08-08 Thread Guido Günther
On Fri, Aug 08, 2008 at 02:30:15PM +0200, Jim Meyering wrote: Guido Günther [EMAIL PROTECTED] wrote: [..snip..] +static int qemudDomainAttachCdromDevice(virDomainPtr dom, +virDomainDeviceDefPtr dev) +{ +struct qemud_driver *driver = (struct

Re: [libvirt] [PATCH]: hostdev passthrough support take #4

2008-08-08 Thread Daniel Veillard
On Fri, Aug 08, 2008 at 04:05:10PM +0200, Guido Günther wrote: Likewise. The same applies here: qemudDomainAttachDevice checked that already, but again - better safe than sorry. Updated patches attached. Okidoc, all look good ! Applied and commited to CVS, thanks a lot for the work, I

Re: [libvirt] [PATCH]: hostdev passthrough support take #4

2008-08-08 Thread Guido Günther
Hi, On Fri, Aug 08, 2008 at 10:34:00AM -0400, Daniel Veillard wrote: [..snip..] I think the only thing missing is extending the descrition in the documentation would you mind adding a description in formatdomain.html(.in) Probably an USB devices section added below the elementsDisks part,