Re: Anybondy interested in libVirt build daemon status mails? (was: Re: [libvirt] [PATCH] [v2] Support kvm-img or qemu-img dynamically)

2009-06-15 Thread Daniel Veillard
On Fri, Jun 12, 2009 at 10:53:01PM +0200, Maximilian Wilhelm wrote: Anno domini 2009 Matthias Bolte scripsit: [...] additional triggers a warning (breaks compilation with --enable-compile-warnings=error) and removing it doesn't change the behavior. As we found this subtle bug(?) - at

Re: Anybondy interested in libVirt build daemon status mails? (was: Re: [libvirt] [PATCH] [v2] Support kvm-img or qemu-img dynamically)

2009-06-15 Thread Daniel P. Berrange
On Fri, Jun 12, 2009 at 10:53:01PM +0200, Maximilian Wilhelm wrote: Anno domini 2009 Matthias Bolte scripsit: As we found this subtle bug(?) - at least it's questionable why the '' was added, which does not change the semantics for the stack var - by the mails our libVirt build daemon sends

Re: [libvirt] [PATCH] [v2] Support kvm-img or qemu-img dynamically

2009-06-11 Thread Daniel Veillard
On Wed, Jun 10, 2009 at 10:28:00AM -0500, Doug Goldstein wrote: This patch adds a new function virFindFileInPath() and uses it to find where a binary lives in the PATH environment variable. Using this, we can dynamically find where utility functions exist (and if they even exists). So such we

Re: [libvirt] [PATCH] [v2] Support kvm-img or qemu-img dynamically

2009-06-11 Thread Matthias Bolte
2009/6/10 Doug Goldstein car...@gentoo.org: This patch adds a new function virFindFileInPath() and uses it to find where a binary lives in the PATH environment variable. [...] +/* + * Finds a requested file in the PATH env. e.g.: + * kvm-img will return /usr/bin/kvm-img + * + * You must

[libvirt] [PATCH] [v2] Support kvm-img or qemu-img dynamically

2009-06-10 Thread Doug Goldstein
This patch adds a new function virFindFileInPath() and uses it to find where a binary lives in the PATH environment variable. Using this, we can dynamically find where utility functions exist (and if they even exists). So such we remove the build-time check for qemu-img and make it dynamic for