Re: [libvirt] [PATCH] Add missing linker flags for MinGW build

On Tue, Apr 28, 2015 at 11:40:02AM +0300, Pavel Fedin wrote: Hello! I have checked. For some reason, $(virnetserverclientmock_la_LDADDS) does not take part anywhere. Here are generated rules: It has to be virnetserverclientmock_la_LIBADD instead. I have tested, works fine. I just wrote

Re: [libvirt] [PATCH] Add missing linker flags for MinGW build

Hello! I have checked. For some reason, $(virnetserverclientmock_la_LDADDS) does not take part anywhere. Here are generated rules: It has to be virnetserverclientmock_la_LIBADD instead. I have tested, works fine. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center

Re: [libvirt] [PATCH] Add missing linker flags for MinGW build

Electronics Research center Russia -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list- boun...@redhat.com] On Behalf Of Martin Kletzander Sent: Monday, April 27, 2015 6:07 PM To: Pavel Fedin Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH] Add missing

Re: [libvirt] [PATCH] Add missing linker flags for MinGW build

Hello! If it works, feel free to close the BZ or reply if it doesn't. I have checked. For some reason, $(virnetserverclientmock_la_LDADDS) does not take part anywhere. Here are generated rules: --- cut --- virnetserverclientmock_la_LINK = $(LIBTOOL) $(AM_V_lt) --tag=CC \

[libvirt] [PATCH] Add missing linker flags for MinGW build

This fix should completely close https://bugzilla.redhat.com/show_bug.cgi?id=1214605 Signed-off-by: Pavel Fedin p.fe...@samsung.com tests/Makefile.am | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/tests/Makefile.am

Re: [libvirt] [PATCH] Add missing linker flags for MinGW build

On Mon, Apr 27, 2015 at 01:40:53PM +0300, Pavel Fedin wrote: This fix should completely close https://bugzilla.redhat.com/show_bug.cgi?id=1214605 Signed-off-by: Pavel Fedin p.fe...@samsung.com tests/Makefile.am | 40 +++- 1 file changed, 27 insertions(+), 13

Re: [libvirt] [PATCH] Add missing linker flags for MinGW build

Hello! Thirdly, I wonder why you needed to add this, is gnulib really needed? is that because of those strdup()s in the file? Why doesn't it fail with gcc then? Fourthly (is that even a word?), I'd ACK this and push it, but just please let me know whether GNULIB_LIBS is really needed

Re: [libvirt] [PATCH] Add missing linker flags for MinGW build

On Mon, Apr 27, 2015 at 05:40:28PM +0300, Pavel Fedin wrote: Hello! Thirdly, I wonder why you needed to add this, is gnulib really needed? is that because of those strdup()s in the file? Why doesn't it fail with gcc then? Fourthly (is that even a word?), I'd ACK this and push it, but just

Re: [libvirt] [PATCH] Add missing linker flags for MinGW build

On Mon, Apr 27, 2015 at 03:07:06PM +0200, Martin Kletzander wrote: On Mon, Apr 27, 2015 at 01:40:53PM +0300, Pavel Fedin wrote: This fix should completely close https://bugzilla.redhat.com/show_bug.cgi?id=1214605 Signed-off-by: Pavel Fedin p.fe...@samsung.com tests/Makefile.am | 40