On 09.03.2014 00:29, Stefan Berger wrote:
From: Stefan Berger stef...@linux.vnet.ibm.com
Avoid the freeing of an array of zero file descriptors in case
of error. Introduce a macro VIR_INIT_N_FD to initialize such
an array's elements to -1.
Signed-off-by: Stefan Berger
On 03/08/2014 04:29 PM, Stefan Berger wrote:
From: Stefan Berger stef...@linux.vnet.ibm.com
Avoid the freeing of an array of zero file descriptors in case
of error. Introduce a macro VIR_INIT_N_FD to initialize such
an array's elements to -1.
Signed-off-by: Stefan Berger
Eric Blake ebl...@redhat.com wrote on 03/10/2014 02:09:58 PM:
From: Eric Blake ebl...@redhat.com
To: Stefan Berger/Watson/IBM@IBMUS, libvir-list@redhat.com,
Cc: la...@laine.org
Date: 03/10/2014 02:24 PM
Subject: Re: [libvirt] [PATCH] BZ1072677: Avoid freeing of 0 file
descriptor
On 03
On 03/10/2014 01:10 PM, Stefan Berger wrote:
Eric Blake ebl...@redhat.com wrote on 03/10/2014 02:09:58 PM:
+/* Initialize an array of file descriptors to -1 */
+# define VIR_INIT_N_FD(ptr, count) \
+vir_init_n_int(ptr, count, -1)
Could also be spelled:
memset(ptr, -1, sizeof(*ptr) *
Eric Blake ebl...@redhat.com wrote on 03/10/2014 05:49:54 PM:
Indeed:
$ git grep memset.*1
src/conf/domain_conf.c:memset(max_idx, -1, sizeof(max_idx));
src/qemu/qemu_command.c:memset(tapfd, -1, tapfdSize *
sizeof(tapfd[0]));
src/qemu/qemu_command.c:memset(vhostfd,
From: Stefan Berger stef...@linux.vnet.ibm.com
Avoid the freeing of an array of zero file descriptors in case
of error. Introduce a macro VIR_INIT_N_FD to initialize such
an array's elements to -1.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
---
src/qemu/qemu_hotplug.c | 14
