Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-13 Thread Daniel Veillard
On Tue, Aug 12, 2008 at 11:58:12PM -0400, Cole Robinson wrote: Daniel Veillard wrote: Fine by me, my only worry is that we are somehow breaking the storage XML format as a result, but I don't think this is widely used at this point (at least with MSDos) and best done earlier than later,

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-12 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote: Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: parted doesn't seem to want the label 'dos', instead wanting 'msdos'. Patch is basically s/dos/msdos/ Hi Cole, This definitely needs to be fixed. FYI, dos

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-12 Thread Daniel Veillard
On Tue, Aug 12, 2008 at 11:12:07AM +0100, Daniel P. Berrange wrote: On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote: Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: parted doesn't seem to want the label 'dos', instead wanting 'msdos'. Patch is basically

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-12 Thread Cole Robinson
Daniel Veillard wrote: On Tue, Aug 12, 2008 at 11:12:07AM +0100, Daniel P. Berrange wrote: On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote: Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: parted doesn't seem to want the label 'dos', instead

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-11 Thread Jim Meyering
Cole Robinson [EMAIL PROTECTED] wrote: parted doesn't seem to want the label 'dos', instead wanting 'msdos'. Patch is basically s/dos/msdos/ Hi Cole, This definitely needs to be fixed. FYI, dos appears to be the preferred name for that partition table type (google for partition table and

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-11 Thread Cole Robinson
Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: parted doesn't seem to want the label 'dos', instead wanting 'msdos'. Patch is basically s/dos/msdos/ Hi Cole, This definitely needs to be fixed. FYI, dos appears to be the preferred name for that partition table type (google

[libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-10 Thread Cole Robinson
parted doesn't seem to want the label 'dos', instead wanting 'msdos'. Patch is basically s/dos/msdos/ Thanks, Cole diff --git a/docs/storage.html.in b/docs/storage.html.in index 40e8e80..8cab480 100644 --- a/docs/storage.html.in +++ b/docs/storage.html.in @@ -258,7 +258,7 @@ libvirt. /p