Re: [libvirt] [PATCH] Changed LPC slot from 1 to 31

2018-07-11 Thread Roman Bogorodskiy
Ivan Mishonov wrote: > --- > src/bhyve/bhyve_command.c | 2 +- > src/bhyve/bhyve_device.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Hi Ivan, Thanks for your contribution! Some general comments: - For quite some time already commits should have the Signed-off line wit

Re: [libvirt] [PATCH] Changed LPC slot from 1 to 31

2018-07-09 Thread Ivan Mishonov
Yes, I talked to him and he said he will review and test. Thanks On 07/09/2018 05:17 PM, Daniel P. Berrangé wrote: On Mon, Jul 09, 2018 at 05:14:35PM +0300, Ivan Mishonov wrote: --- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 de

Re: [libvirt] [PATCH] Changed LPC slot from 1 to 31

2018-07-09 Thread Daniel P . Berrangé
On Mon, Jul 09, 2018 at 05:14:35PM +0300, Ivan Mishonov wrote: > --- > src/bhyve/bhyve_command.c | 2 +- > src/bhyve/bhyve_device.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c > index 802997bd2d..e595b3d6c1 1

[libvirt] [PATCH] Changed LPC slot from 1 to 31

2018-07-09 Thread Ivan Mishonov
--- src/bhyve/bhyve_command.c | 2 +- src/bhyve/bhyve_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 802997bd2d..e595b3d6c1 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -329