Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-04-27 Thread Martin Kletzander
On Sat, Apr 25, 2015 at 07:30:21PM +0300, Roman Bogorodskiy wrote: Martin Kletzander wrote: On Tue, Mar 10, 2015 at 02:27:44PM +0100, Ján Tomko wrote: On Tue, Mar 10, 2015 at 01:45:38PM +0100, Martin Kletzander wrote: On Tue, Mar 10, 2015 at 12:24:03PM +, Daniel P. Berrange wrote: On

Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-04-25 Thread Roman Bogorodskiy
Martin Kletzander wrote: On Tue, Mar 10, 2015 at 02:27:44PM +0100, Ján Tomko wrote: On Tue, Mar 10, 2015 at 01:45:38PM +0100, Martin Kletzander wrote: On Tue, Mar 10, 2015 at 12:24:03PM +, Daniel P. Berrange wrote: On Tue, Mar 10, 2015 at 01:05:22PM +0100, Ján Tomko wrote: These

Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-03-11 Thread Martin Kletzander
On Tue, Mar 10, 2015 at 02:27:44PM +0100, Ján Tomko wrote: On Tue, Mar 10, 2015 at 01:45:38PM +0100, Martin Kletzander wrote: On Tue, Mar 10, 2015 at 12:24:03PM +, Daniel P. Berrange wrote: On Tue, Mar 10, 2015 at 01:05:22PM +0100, Ján Tomko wrote: These are the failing qemuxml2argvtest

Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-03-10 Thread Ján Tomko
On Mon, Mar 09, 2015 at 02:03:16PM +0100, Martin Kletzander wrote: On Mon, Mar 09, 2015 at 10:09:17AM +, Daniel P. Berrange wrote: On Mon, Mar 09, 2015 at 11:01:31AM +0100, Martin Kletzander wrote: On Thu, Mar 05, 2015 at 11:09:41AM +, Daniel P. Berrange wrote: On Thu, Mar 05, 2015

Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-03-10 Thread Daniel P. Berrange
On Tue, Mar 10, 2015 at 01:05:22PM +0100, Ján Tomko wrote: On Mon, Mar 09, 2015 at 02:03:16PM +0100, Martin Kletzander wrote: On Mon, Mar 09, 2015 at 10:09:17AM +, Daniel P. Berrange wrote: On Mon, Mar 09, 2015 at 11:01:31AM +0100, Martin Kletzander wrote: On Thu, Mar 05, 2015 at

Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-03-10 Thread Ján Tomko
On Tue, Mar 10, 2015 at 01:45:38PM +0100, Martin Kletzander wrote: On Tue, Mar 10, 2015 at 12:24:03PM +, Daniel P. Berrange wrote: On Tue, Mar 10, 2015 at 01:05:22PM +0100, Ján Tomko wrote: These are the failing qemuxml2argvtest cases: 60) QEMU XML-2-ARGV hugepages-pages ... libvirt:

Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-03-10 Thread Martin Kletzander
On Tue, Mar 10, 2015 at 12:24:03PM +, Daniel P. Berrange wrote: On Tue, Mar 10, 2015 at 01:05:22PM +0100, Ján Tomko wrote: On Mon, Mar 09, 2015 at 02:03:16PM +0100, Martin Kletzander wrote: On Mon, Mar 09, 2015 at 10:09:17AM +, Daniel P. Berrange wrote: On Mon, Mar 09, 2015 at

Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-03-09 Thread Martin Kletzander
On Mon, Mar 09, 2015 at 10:09:17AM +, Daniel P. Berrange wrote: On Mon, Mar 09, 2015 at 11:01:31AM +0100, Martin Kletzander wrote: On Thu, Mar 05, 2015 at 11:09:41AM +, Daniel P. Berrange wrote: On Thu, Mar 05, 2015 at 12:05:52PM +0100, Ján Tomko wrote: Explicitly request that

Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-03-09 Thread Martin Kletzander
On Thu, Mar 05, 2015 at 11:09:41AM +, Daniel P. Berrange wrote: On Thu, Mar 05, 2015 at 12:05:52PM +0100, Ján Tomko wrote: Explicitly request that virNumaNodeIsAvailable not be inlined. This fixes the test suite when building with clang (3.5.1). Huh, so clang will inline functions, even

Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-03-09 Thread Daniel P. Berrange
On Mon, Mar 09, 2015 at 11:01:31AM +0100, Martin Kletzander wrote: On Thu, Mar 05, 2015 at 11:09:41AM +, Daniel P. Berrange wrote: On Thu, Mar 05, 2015 at 12:05:52PM +0100, Ján Tomko wrote: Explicitly request that virNumaNodeIsAvailable not be inlined. This fixes the test suite when

[libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-03-05 Thread Ján Tomko
Explicitly request that virNumaNodeIsAvailable not be inlined. This fixes the test suite when building with clang (3.5.1). --- This only leaves the mysterious check-protocol failure. And too large stack frame size when building the tests with -O0. src/internal.h | 10 ++

Re: [libvirt] [PATCH] Do not inline virNumaNodeIsAvailable

2015-03-05 Thread Daniel P. Berrange
On Thu, Mar 05, 2015 at 12:05:52PM +0100, Ján Tomko wrote: Explicitly request that virNumaNodeIsAvailable not be inlined. This fixes the test suite when building with clang (3.5.1). Huh, so clang will inline functions, even if they are exported in the .so library ? Is there some clang compiler