Re: [libvirt] [PATCH] Fix 'virsh pool-list' locking issue

2008-12-11 Thread Cole Robinson
Daniel Veillard wrote: On Tue, Dec 09, 2008 at 01:50:37PM -0500, Cole Robinson wrote: Running 'virsh pool-list' seems to deadlock libvirtd. Dan gave me some debugging tips, and I managed to track it down to the poolGetAutostart function. The attached patch fixes the issue. Argh, +1 I

Re: [libvirt] [PATCH] Fix 'virsh pool-list' locking issue

2008-12-10 Thread Daniel Veillard
On Wed, Dec 10, 2008 at 11:23:35AM +, Daniel P. Berrange wrote: On Wed, Dec 10, 2008 at 08:38:15AM +0100, Daniel Veillard wrote: On Tue, Dec 09, 2008 at 01:50:37PM -0500, Cole Robinson wrote: Running 'virsh pool-list' seems to deadlock libvirtd. Dan gave me some debugging tips, and I

Re: [libvirt] [PATCH] Fix 'virsh pool-list' locking issue

2008-12-10 Thread Daniel P. Berrange
On Wed, Dec 10, 2008 at 01:07:47PM +0100, Daniel Veillard wrote: On Wed, Dec 10, 2008 at 11:23:35AM +, Daniel P. Berrange wrote: On Wed, Dec 10, 2008 at 08:38:15AM +0100, Daniel Veillard wrote: On Tue, Dec 09, 2008 at 01:50:37PM -0500, Cole Robinson wrote: Running 'virsh pool-list'

Re: [libvirt] [PATCH] Fix 'virsh pool-list' locking issue

2008-12-10 Thread Daniel P. Berrange
On Wed, Dec 10, 2008 at 08:38:15AM +0100, Daniel Veillard wrote: On Tue, Dec 09, 2008 at 01:50:37PM -0500, Cole Robinson wrote: Running 'virsh pool-list' seems to deadlock libvirtd. Dan gave me some debugging tips, and I managed to track it down to the poolGetAutostart function. The

[libvirt] [PATCH] Fix 'virsh pool-list' locking issue

2008-12-09 Thread Cole Robinson
Running 'virsh pool-list' seems to deadlock libvirtd. Dan gave me some debugging tips, and I managed to track it down to the poolGetAutostart function. The attached patch fixes the issue. Thanks, Cole diff --git a/src/storage_driver.c b/src/storage_driver.c index 63593cc..2432a9a 100644 ---

Re: [libvirt] [PATCH] Fix 'virsh pool-list' locking issue

2008-12-09 Thread Daniel Veillard
On Tue, Dec 09, 2008 at 01:50:37PM -0500, Cole Robinson wrote: Running 'virsh pool-list' seems to deadlock libvirtd. Dan gave me some debugging tips, and I managed to track it down to the poolGetAutostart function. The attached patch fixes the issue. Argh, +1 I wonder why the CIL static