Re: [libvirt] [PATCH] Revert "qemu: directly create virResctrlInfo ignoring capabilities"

2019-12-10 Thread Cole Robinson
On 12/10/19 5:26 AM, Daniel P. Berrangé wrote: > This reverts commit 7be5fe66cd024b9ffba7c52cdbf5effedeac2c0d. > > This commit broke resctrl, because it missed the fact that the > virResctrlInfoGetCache() has side-effects causing it to actually > change the virResctrlInfo parameter, not merely

[libvirt] [PATCH] Revert "qemu: directly create virResctrlInfo ignoring capabilities"

2019-12-10 Thread Daniel P . Berrangé
This reverts commit 7be5fe66cd024b9ffba7c52cdbf5effedeac2c0d. This commit broke resctrl, because it missed the fact that the virResctrlInfoGetCache() has side-effects causing it to actually change the virResctrlInfo parameter, not merely get data from it. This code will need some refactoring