Re: [libvirt] [PATCH] Revert "Introduce QEMU_CAPS_ARM_VIRT_PCI"

2015-07-01 Thread Cole Robinson
On 06/30/2015 06:01 AM, Michal Privoznik wrote: > On 29.06.2015 09:58, Peter Krempa wrote: >> The capability was not used up to the feature freeze. >> >> This reverts commit 7f3515b4bb677d0ead1887547efc844e4761268a. >> --- >> src/qemu/qemu_capabilities.c | 4 >> src/qemu/qemu_capabilities.h |

Re: [libvirt] [PATCH] Revert "Introduce QEMU_CAPS_ARM_VIRT_PCI"

2015-06-30 Thread Peter Krempa
On Tue, Jun 30, 2015 at 13:28:12 +0200, Ján Tomko wrote: > On Mon, Jun 29, 2015 at 09:58:19AM +0200, Peter Krempa wrote: > > The capability was not used up to the feature freeze. > > > > This reverts commit 7f3515b4bb677d0ead1887547efc844e4761268a. > > --- > > src/qemu/qemu_capabilities.c | 4 ---

Re: [libvirt] [PATCH] Revert "Introduce QEMU_CAPS_ARM_VIRT_PCI"

2015-06-30 Thread Ján Tomko
On Mon, Jun 29, 2015 at 09:58:19AM +0200, Peter Krempa wrote: > The capability was not used up to the feature freeze. > > This reverts commit 7f3515b4bb677d0ead1887547efc844e4761268a. > --- > src/qemu/qemu_capabilities.c | 4 > src/qemu/qemu_capabilities.h | 1 - > 2 files changed, 5 deletio

Re: [libvirt] [PATCH] Revert "Introduce QEMU_CAPS_ARM_VIRT_PCI"

2015-06-30 Thread Peter Krempa
On Tue, Jun 30, 2015 at 14:06:27 +0300, Pavel Fedin wrote: > Hello! > > > I'm inclined to ACK this, but I'd love to hear committer or original > > author's opinions. > > 1. Does it really harm? We are going to use it soon. Unfortunately looks > like we have opinion > collision with Cole who sa

Re: [libvirt] [PATCH] Revert "Introduce QEMU_CAPS_ARM_VIRT_PCI"

2015-06-30 Thread Pavel Fedin
ist@redhat.com > Cc: Pavel Fedin; Cole Robinson > Subject: Re: [libvirt] [PATCH] Revert "Introduce QEMU_CAPS_ARM_VIRT_PCI" > > On 29.06.2015 09:58, Peter Krempa wrote: > > The capability was not used up to the feature freeze. > > > > This reverts commit 7f351

Re: [libvirt] [PATCH] Revert "Introduce QEMU_CAPS_ARM_VIRT_PCI"

2015-06-30 Thread Michal Privoznik
On 29.06.2015 09:58, Peter Krempa wrote: > The capability was not used up to the feature freeze. > > This reverts commit 7f3515b4bb677d0ead1887547efc844e4761268a. > --- > src/qemu/qemu_capabilities.c | 4 > src/qemu/qemu_capabilities.h | 1 - > 2 files changed, 5 deletions(-) > > diff --git

[libvirt] [PATCH] Revert "Introduce QEMU_CAPS_ARM_VIRT_PCI"

2015-06-29 Thread Peter Krempa
The capability was not used up to the feature freeze. This reverts commit 7f3515b4bb677d0ead1887547efc844e4761268a. --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 1 - 2 files changed, 5 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilitie