Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-10-06 Thread Daniel P. Berrange
On Mon, Oct 05, 2009 at 02:34:05PM -0700, David Lutterkort wrote: On Mon, 2009-10-05 at 17:34 +0100, Daniel P. Berrange wrote: With the domain XML format, we did have a few abortive attempts at indicating in the live XML, whether an attribute was from the persistent config, vs dynamically

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-10-06 Thread Laine Stump
On 10/06/2009 05:13 AM, Daniel P. Berrange wrote: On Mon, Oct 05, 2009 at 02:34:05PM -0700, David Lutterkort wrote: On Mon, 2009-10-05 at 17:34 +0100, Daniel P. Berrange wrote: With the domain XML format, we did have a few abortive attempts at indicating in the live XML, whether an

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-10-06 Thread Daniel P. Berrange
On Tue, Oct 06, 2009 at 09:55:06AM -0400, Laine Stump wrote: On 10/06/2009 05:13 AM, Daniel P. Berrange wrote: On Mon, Oct 05, 2009 at 02:34:05PM -0700, David Lutterkort wrote: On Mon, 2009-10-05 at 17:34 +0100, Daniel P. Berrange wrote: With the domain XML format, we did have a

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-10-06 Thread Laine Stump
On 10/06/2009 10:13 AM, Daniel P. Berrange wrote: This was a bug in the original patch, corrected by this set of patches: https://fedorahosted.org/pipermail/netcf-devel/2009-September/000280.html Once those patches are applied, only the IP (v4) addresses currently on the device are returned

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-10-06 Thread David Lutterkort
On Tue, 2009-10-06 at 10:13 +0100, Daniel P. Berrange wrote: The live XML should *always* say what the inteface is doing right now. And from the rest of this exchange, I think the word 'only' should be added to that sentence. In other words, the XML for live setups contains *only* what we have

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-10-06 Thread David Lutterkort
On Tue, 2009-10-06 at 14:17 -0400, Laine Stump wrote: On 10/06/2009 01:36 PM, David Lutterkort wrote: On Tue, 2009-10-06 at 10:13 +0100, Daniel P. Berrange wrote: The live XML should *always* say what the inteface is doing right now. And from the rest of this exchange, I

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-10-05 Thread Daniel P. Berrange
On Tue, Sep 29, 2009 at 04:02:30PM -0400, Laine Stump wrote: From: root r...@vlap.laine.org This patch adds the flag VIR_INTERFACE_XML_INACTIVE to virInterfaceGetXMLDesc's flags. When it is *not* set (the default), the live interface info will be returned in the XML. in particular, the IP

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-10-05 Thread Daniel P. Berrange
On Mon, Oct 05, 2009 at 12:18:33PM -0400, Laine Stump wrote: On 10/05/2009 07:02 AM, Daniel P. Berrange wrote: On Tue, Sep 29, 2009 at 04:02:30PM -0400, Laine Stump wrote: From: rootr...@vlap.laine.org This patch adds the flag VIR_INTERFACE_XML_INACTIVE to virInterfaceGetXMLDesc's

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-10-05 Thread David Lutterkort
On Mon, 2009-10-05 at 12:02 +0100, Daniel P. Berrange wrote: On Tue, Sep 29, 2009 at 04:02:30PM -0400, Laine Stump wrote: From: root r...@vlap.laine.org This patch adds the flag VIR_INTERFACE_XML_INACTIVE to virInterfaceGetXMLDesc's flags. When it is *not* set (the default), the live

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-10-05 Thread David Lutterkort
On Mon, 2009-10-05 at 17:34 +0100, Daniel P. Berrange wrote: With the domain XML format, we did have a few abortive attempts at indicating in the live XML, whether an attribute was from the persistent config, vs dynamically added to live config, but it all ended up as rather a mess. Here's a

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-09-30 Thread Paolo Bonzini
This patch adds the flag VIR_INTERFACE_XML_INACTIVE to virInterfaceGetXMLDesc's flags. What about calling it instead VIR_INTERFACE_XML_CONFIG and adding a dummy (0) VIR_INTERFACE_XML_DEVICE, and corresponding --config/--device flags to the virsh command? This would match the source

[libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-09-29 Thread Laine Stump
From: root r...@vlap.laine.org This patch adds the flag VIR_INTERFACE_XML_INACTIVE to virInterfaceGetXMLDesc's flags. When it is *not* set (the default), the live interface info will be returned in the XML. in particular, the IP address(es) and netmask(s) will be retrieved by querying the device

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-09-29 Thread Laine Stump
On 09/29/2009 04:02 PM, Laine Stump wrote: From: rootr...@vlap.laine.org Note that I accidentally did the local commit as root, and didn't notice it until now. If this patch gets committed, please change the From: first. This patch adds the flag VIR_INTERFACE_XML_INACTIVE to

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-09-29 Thread Paolo Bonzini
On 09/29/2009 10:02 PM, Laine Stump wrote: From: rootr...@vlap.laine.org This patch adds the flag VIR_INTERFACE_XML_INACTIVE to virInterfaceGetXMLDesc's flags. What about calling it instead VIR_INTERFACE_XML_CONFIG and adding a dummy (0) VIR_INTERFACE_XML_DEVICE, and corresponding

Re: [libvirt] [PATCH] Support reporting live interface IP/netmask.

2009-09-29 Thread Daniel Veillard
On Tue, Sep 29, 2009 at 11:13:56PM +0200, Paolo Bonzini wrote: On 09/29/2009 10:02 PM, Laine Stump wrote: From: rootr...@vlap.laine.org This patch adds the flag VIR_INTERFACE_XML_INACTIVE to virInterfaceGetXMLDesc's flags. What about calling it instead VIR_INTERFACE_XML_CONFIG and adding a