Re: [libvirt] [PATCH] build: Fix uninstall when WITH_APPARMOR_PROFILES is defined

2018-11-14 Thread Andrea Bolognani
On Tue, 2018-11-13 at 12:04 -0700, Jim Fehlig wrote: > On 11/13/18 10:14 AM, Andrea Bolognani wrote: > > > +uninstall-apparmor-local: > > > + rm -f "$(APPARMOR_LOCAL_DIR)/usr.lib.libvirt.virt-aa-helper" > > > + rmdir $(APPARMOR_LOCAL_DIR) || : > > > > Missing quotes here as well. Once you fix

Re: [libvirt] [PATCH] build: Fix uninstall when WITH_APPARMOR_PROFILES is defined

2018-11-13 Thread Jim Fehlig
On 11/13/18 10:14 AM, Andrea Bolognani wrote: On Wed, 2018-11-07 at 17:44 -0700, Jim Fehlig wrote: [...] @@ -96,6 +96,10 @@ install-apparmor-local: 'usr.lib.libvirt.virt-aa-helper'" \ >$(APPARMOR_LOCAL_DIR)/usr.lib.libvirt.virt-aa-helper Pre-existing lack of

Re: [libvirt] [PATCH] build: Fix uninstall when WITH_APPARMOR_PROFILES is defined

2018-11-13 Thread Andrea Bolognani
On Wed, 2018-11-07 at 17:44 -0700, Jim Fehlig wrote: [...] > @@ -96,6 +96,10 @@ install-apparmor-local: > 'usr.lib.libvirt.virt-aa-helper'" \ > >$(APPARMOR_LOCAL_DIR)/usr.lib.libvirt.virt-aa-helper Pre-existing lack of quoting... I've fixed it with a trivial patch

[libvirt] [PATCH] build: Fix uninstall when WITH_APPARMOR_PROFILES is defined

2018-11-07 Thread Jim Fehlig
When libvirt configuration includes '--with-apparmor-profiles', the make uninstall target fails make[1]: Entering directory '/home/jim/upstream/libvirt/examples' ( cd '/etc/apparmor.d//abstractions' && rm -f libvirt-qemu libvirt-lxc ) ( cd '/etc/apparmor.d/' && rm -f