Re: [libvirt] [PATCH] build: Solve mingw build clash with DATADIR

2019-08-08 Thread Andrea Bolognani
On Wed, 2019-08-07 at 21:15 -0500, Eric Blake wrote: > I'm reverting the patch under the build-breaker rules, while trying to > reproduce the cross-compilation locally rather than relying solely on > CI. My local testing that proved that #pragma push_macro works with gcc > was obviously not

Re: [libvirt] [PATCH] build: Solve mingw build clash with DATADIR

2019-08-07 Thread Eric Blake
On 8/7/19 9:59 AM, Michal Privoznik wrote: > On 7/31/19 9:30 PM, Eric Blake wrote: >> Commit fed58d83 was a hack to fix a mingw build failure due to header >> inclusion order resulting in a clash over the use of DATADIR, by >> repeating a trick made several other times in the past of tweaking >>

Re: [libvirt] [PATCH] build: Solve mingw build clash with DATADIR

2019-08-07 Thread Michal Privoznik
On 7/31/19 9:30 PM, Eric Blake wrote: Commit fed58d83 was a hack to fix a mingw build failure due to header inclusion order resulting in a clash over the use of DATADIR, by repeating a trick made several other times in the past of tweaking inclusion order until it goes away. Better is to revert

Re: [libvirt] [PATCH] build: Solve mingw build clash with DATADIR

2019-08-07 Thread Eric Blake
On 7/31/19 2:30 PM, Eric Blake wrote: > Commit fed58d83 was a hack to fix a mingw build failure due to header > inclusion order resulting in a clash over the use of DATADIR, by > repeating a trick made several other times in the past of tweaking > inclusion order until it goes away. Better is to

[libvirt] [PATCH] build: Solve mingw build clash with DATADIR

2019-07-31 Thread Eric Blake
Commit fed58d83 was a hack to fix a mingw build failure due to header inclusion order resulting in a clash over the use of DATADIR, by repeating a trick made several other times in the past of tweaking inclusion order until it goes away. Better is to revert that, and instead use pragmas to avoid