Re: [libvirt] [PATCH] build: add compiler attributes to virUUIDParse

2011-10-14 Thread Daniel P. Berrange
On Thu, Oct 13, 2011 at 12:24:02PM -0600, Eric Blake wrote: On 10/13/2011 02:55 AM, Daniel Veillard wrote: On Wed, Oct 12, 2011 at 05:27:40PM -0600, Eric Blake wrote: Coverity complained that most, but not all, clients of virUUIDParse were checking for errors. Silence those coverity warnings

Re: [libvirt] [PATCH] build: add compiler attributes to virUUIDParse

2011-10-13 Thread Daniel Veillard
On Wed, Oct 12, 2011 at 05:27:40PM -0600, Eric Blake wrote: Coverity complained that most, but not all, clients of virUUIDParse were checking for errors. Silence those coverity warnings by explicitly marking the cases where we trust the input, and fixing one instance that really should have

Re: [libvirt] [PATCH] build: add compiler attributes to virUUIDParse

2011-10-13 Thread Eric Blake
On 10/13/2011 02:55 AM, Daniel Veillard wrote: On Wed, Oct 12, 2011 at 05:27:40PM -0600, Eric Blake wrote: Coverity complained that most, but not all, clients of virUUIDParse were checking for errors. Silence those coverity warnings by explicitly marking the cases where we trust the input, and

Re: [libvirt] [PATCH] build: add compiler attributes to virUUIDParse

2011-10-13 Thread Daniel Veillard
On Thu, Oct 13, 2011 at 12:24:02PM -0600, Eric Blake wrote: On 10/13/2011 02:55 AM, Daniel Veillard wrote: On Wed, Oct 12, 2011 at 05:27:40PM -0600, Eric Blake wrote: @@ -129,9 +129,6 @@ virUUIDParse(const char *uuidstr, unsigned char *uuid) { const char *cur; int i; -if

[libvirt] [PATCH] build: add compiler attributes to virUUIDParse

2011-10-12 Thread Eric Blake
Coverity complained that most, but not all, clients of virUUIDParse were checking for errors. Silence those coverity warnings by explicitly marking the cases where we trust the input, and fixing one instance that really should have been checking. In particular, this silences about half of the 46