[libvirt] [PATCH] conf: fix crash when hotplug a channel chr device with no target

2015-01-13 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1181408 when we try to hotplug a channel chr device with no target, we will get success(which should fail) in virDomainChrDefParseXML, because we use goto cleanup this place and return def.then cause a big problem in virDomainChrEquals(touch a shouldn't

Re: [libvirt] [PATCH] conf: fix crash when hotplug a channel chr device with no target

2015-01-13 Thread Ján Tomko
On 01/13/2015 09:41 AM, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1181408 when we try to hotplug a channel chr device with no target, we will get success(which should fail) in virDomainChrDefParseXML, because we use goto cleanup this place and return def.then cause a

Re: [libvirt] [PATCH] conf: fix crash when hotplug a channel chr device with no target

2015-01-13 Thread lhuang
On 01/13/2015 05:34 PM, Ján Tomko wrote: On 01/13/2015 09:41 AM, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1181408 when we try to hotplug a channel chr device with no target, we will get success(which should fail) in virDomainChrDefParseXML, because we use goto cleanup