Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-07-02 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 07:34:07PM +0200, Michal Privoznik wrote: On 28.06.2013 17:01, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 04:45:08PM +0200, Michal Privoznik wrote: On 28.06.2013 15:55, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 03:31:17PM +0200, Michal Privoznik wrote:

Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-07-02 Thread Michal Privoznik
On 02.07.2013 13:27, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 07:34:07PM +0200, Michal Privoznik wrote: On 28.06.2013 17:01, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 04:45:08PM +0200, Michal Privoznik wrote: On 28.06.2013 15:55, Daniel P. Berrange wrote: On Fri, Jun 28, 2013

Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-07-02 Thread Daniel P. Berrange
On Tue, Jul 02, 2013 at 01:49:35PM +0200, Michal Privoznik wrote: On 02.07.2013 13:27, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 07:34:07PM +0200, Michal Privoznik wrote: On 28.06.2013 17:01, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 04:45:08PM +0200, Michal Privoznik wrote:

[libvirt] [PATCH] domain_conf: Include the correct console alias

2013-06-28 Thread Michal Privoznik
For some crazy backward compatibility, a console can by just an alias to a serial device. This is detected in the XML formating function which takes the values to format from corresponding serial device. Including the device alias. This results in wrong alias being written into the XML definition:

Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 03:31:17PM +0200, Michal Privoznik wrote: For some crazy backward compatibility, a console can by just an alias to a serial device. This is detected in the XML formating function which takes the values to format from corresponding serial device. Including the device

Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-06-28 Thread Michal Privoznik
On 28.06.2013 15:55, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 03:31:17PM +0200, Michal Privoznik wrote: For some crazy backward compatibility, a console can by just an alias to a serial device. This is detected in the XML formating function which takes the values to format from

Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 04:45:08PM +0200, Michal Privoznik wrote: On 28.06.2013 15:55, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 03:31:17PM +0200, Michal Privoznik wrote: For some crazy backward compatibility, a console can by just an alias to a serial device. This is detected in

Re: [libvirt] [PATCH] domain_conf: Include the correct console alias

2013-06-28 Thread Michal Privoznik
On 28.06.2013 17:01, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 04:45:08PM +0200, Michal Privoznik wrote: On 28.06.2013 15:55, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 03:31:17PM +0200, Michal Privoznik wrote: For some crazy backward compatibility, a console can by just an