Re: [libvirt] [PATCH] events: Avoid double free possibility on remote call failure

2017-06-25 Thread John Ferlan
On 06/25/2017 04:51 AM, Michal Privoznik wrote: > On 06/25/2017 12:34 AM, John Ferlan wrote: >> >> >> On 06/24/2017 01:13 PM, Michal Privoznik wrote: >>> On 06/24/2017 01:26 PM, John Ferlan wrote: On 06/23/2017 05:39 AM, Michal Privoznik wrote: > On 06/23/2017 12:10 AM, John

Re: [libvirt] [PATCH] events: Avoid double free possibility on remote call failure

2017-06-25 Thread Michal Privoznik
On 06/25/2017 12:34 AM, John Ferlan wrote: > > > On 06/24/2017 01:13 PM, Michal Privoznik wrote: >> On 06/24/2017 01:26 PM, John Ferlan wrote: >>> >>> >>> On 06/23/2017 05:39 AM, Michal Privoznik wrote: On 06/23/2017 12:10 AM, John Ferlan wrote: > If a remote call fails during event

Re: [libvirt] [PATCH] events: Avoid double free possibility on remote call failure

2017-06-25 Thread John Ferlan
On 06/24/2017 01:13 PM, Michal Privoznik wrote: > On 06/24/2017 01:26 PM, John Ferlan wrote: >> >> >> On 06/23/2017 05:39 AM, Michal Privoznik wrote: >>> On 06/23/2017 12:10 AM, John Ferlan wrote: If a remote call fails during event registration (more than likely from a network failure

Re: [libvirt] [PATCH] events: Avoid double free possibility on remote call failure

2017-06-25 Thread Michal Privoznik
On 06/24/2017 01:26 PM, John Ferlan wrote: > > > On 06/23/2017 05:39 AM, Michal Privoznik wrote: >> On 06/23/2017 12:10 AM, John Ferlan wrote: >>> If a remote call fails during event registration (more than likely from >>> a network failure or remote libvirtd restart timed just right), then when

Re: [libvirt] [PATCH] events: Avoid double free possibility on remote call failure

2017-06-24 Thread John Ferlan
On 06/23/2017 05:39 AM, Michal Privoznik wrote: > On 06/23/2017 12:10 AM, John Ferlan wrote: >> If a remote call fails during event registration (more than likely from >> a network failure or remote libvirtd restart timed just right), then when >> calling the virObjectEventStateDeregisterID we

Re: [libvirt] [PATCH] events: Avoid double free possibility on remote call failure

2017-06-23 Thread Michal Privoznik
On 06/23/2017 12:10 AM, John Ferlan wrote: > If a remote call fails during event registration (more than likely from > a network failure or remote libvirtd restart timed just right), then when > calling the virObjectEventStateDeregisterID we don't want to call the > registered @freecb function

[libvirt] [PATCH] events: Avoid double free possibility on remote call failure

2017-06-22 Thread John Ferlan
If a remote call fails during event registration (more than likely from a network failure or remote libvirtd restart timed just right), then when calling the virObjectEventStateDeregisterID we don't want to call the registered @freecb function because that breaks our contract that we would only