Re: [libvirt] [PATCH] introducing source name (for logical storage pools)

2008-09-03 Thread Daniel Veillard
On Tue, Sep 02, 2008 at 11:59:35AM -0400, David Lively wrote: On Tue, 2008-09-02 at 17:54 +0200, Jim Meyering wrote: Daniel Veillard [EMAIL PROTECTED] wrote: diff --git a/src/storage_conf.c b/src/storage_conf.c index 2f6093b..37a2040 100644 --- a/src/storage_conf.c +++

Re: [libvirt] [PATCH] introducing source name (for logical storage pools)

2008-09-02 Thread Daniel Veillard
On Fri, Aug 29, 2008 at 03:49:27PM -0400, David Lively wrote: Hi Jim - I've attached a (very) small incremental patch (i.e., to be applied after the one you've already merged) that addresses a couple things I noticed missing: (a) documents the new source name element in

Re: [libvirt] [PATCH] introducing source name (for logical storage pools)

2008-09-02 Thread David Lively
Thanks Daniel. I just merged in your changes. You seem to be missing a small incremental change (checking the strdup return value for NULL), attached. Dave On Tue, 2008-09-02 at 16:17 +0200, Daniel Veillard wrote: On Fri, Aug 29, 2008 at 03:49:27PM -0400, David Lively wrote: Hi Jim -

Re: [libvirt] [PATCH] introducing source name (for logical storage pools)

2008-08-22 Thread Daniel P. Berrange
On Thu, Aug 21, 2008 at 10:17:49AM -0400, David Lively wrote: Oops - that was against an old base. Sorry. Here's the new one. Also fixed a few other issues ... Ok, this gets my vote to commit. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |:

Re: [libvirt] [PATCH] introducing source name (for logical storage pools)

2008-08-21 Thread David Lively
Oops - that was against an old base. Sorry. Here's the new one. Also fixed a few other issues ... Dave On Mon, 2008-08-18 at 12:12 -0400, David Lively wrote: Same patch, resubmitted after fixing allocation issue you pointed out. Looking more closely, I notice it was leaking when

Re: [libvirt] [PATCH] introducing source name (for logical storage pools)

2008-08-15 Thread Daniel Berrange
On Fri, Aug 08, 2008 at 03:17:52PM -0400, David Lively wrote: Daniel B proposed having storage pool discovery return a bunch of XML storage source elements, rather than full pool elements (which contain target-dependent details like the local pool name and device or mount path -- things

Re: [libvirt] [PATCH] introducing source name (for logical storage pools)

2008-08-12 Thread Daniel Veillard
On Fri, Aug 08, 2008 at 03:17:52PM -0400, David Lively wrote: Hi Folks - This small patch is a proposed prerequisite for the storage pool discovery patch I submitted last week. Daniel B proposed having storage pool discovery return a bunch of XML storage source elements, rather than

[libvirt] [PATCH] introducing source name (for logical storage pools)

2008-08-08 Thread David Lively
Hi Folks - This small patch is a proposed prerequisite for the storage pool discovery patch I submitted last week. Daniel B proposed having storage pool discovery return a bunch of XML storage source elements, rather than full pool elements (which contain target-dependent details like the