Re: [libvirt] [PATCH] libxl: libxl_get_max_cpus returning a libxl error from 4.4 onward

2013-12-18 Thread Dario Faggioli
On mer, 2013-12-18 at 07:39 +0100, Martin Kletzander wrote: On Tue, Dec 17, 2013 at 06:43:25PM +0100, Dario Faggioli wrote: diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 692c3b7..a31b094 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@

[libvirt] [PATCH] libxl: libxl_get_max_cpus returning a libxl error from 4.4 onward

2013-12-17 Thread Dario Faggioli
Starting from commit 2e82c18c in Xen (will be included in Xen 4.4) libxl_get_max_cpus() start returning a proper libxl error code, in case of failure. It returning 0 is now basically impossible but, theoretically, still wrong, not to mention that using '= 0' makes this correct for both Xen 4.4 and

Re: [libvirt] [PATCH] libxl: libxl_get_max_cpus returning a libxl error from 4.4 onward

2013-12-17 Thread Martin Kletzander
On Tue, Dec 17, 2013 at 06:43:25PM +0100, Dario Faggioli wrote: Starting from commit 2e82c18c in Xen (will be included in Xen 4.4) libxl_get_max_cpus() start returning a proper libxl error code, in case of failure. It returning 0 is now basically impossible but, theoretically, still wrong, not