Re: [libvirt] [PATCH] log: actually do substring matches with fnmatch

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 11:59:31AM +0200, Erik Skultety wrote: > On Mon, May 14, 2018 at 02:53:49PM +0100, Daniel P. Berrangé wrote: > > Historically we matched log filters with strstr(), and when switching to > > fnmatch in cbb0fd3cfdc287f6f4653ef1f04a7cfb2ea51b27, it was stated that > > we would

Re: [libvirt] [PATCH] log: actually do substring matches with fnmatch

2018-05-16 Thread Erik Skultety
On Mon, May 14, 2018 at 02:53:49PM +0100, Daniel P. Berrangé wrote: > Historically we matched log filters with strstr(), and when switching to > fnmatch in cbb0fd3cfdc287f6f4653ef1f04a7cfb2ea51b27, it was stated that > we would continue to match substrings, with "foo" being equivalent to > "*foo*".

[libvirt] [PATCH] log: actually do substring matches with fnmatch

2018-05-14 Thread Daniel P . Berrangé
Historically we matched log filters with strstr(), and when switching to fnmatch in cbb0fd3cfdc287f6f4653ef1f04a7cfb2ea51b27, it was stated that we would continue to match substrings, with "foo" being equivalent to "*foo*". Unfortuntely I forget to provide the code to actually make that happen. Thi