Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-11-12 Thread Michal Privoznik
On 11.11.2014 23:45, Anirban Chakraborty wrote: On 11/10/14, 3:13 PM, Eric Blake ebl...@redhat.com wrote: On 11/10/2014 03:41 PM, Anirban Chakraborty wrote: BTW: it would be nice if you can version you patches. I mean, this is what, 4th or 5th version? Say that in subject explicitly

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-11-12 Thread Anirban Chakraborty
On 11/12/14, 2:53 AM, Michal Privoznik mpriv...@redhat.com wrote: On 11.11.2014 23:45, Anirban Chakraborty wrote: On 11/10/14, 3:13 PM, Eric Blake ebl...@redhat.com wrote: On 11/10/2014 03:41 PM, Anirban Chakraborty wrote: BTW: it would be nice if you can version you patches. I mean,

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-11-11 Thread Anirban Chakraborty
On 11/10/14, 3:13 PM, Eric Blake ebl...@redhat.com wrote: On 11/10/2014 03:41 PM, Anirban Chakraborty wrote: BTW: it would be nice if you can version you patches. I mean, this is what, 4th or 5th version? Say that in subject explicitly please. You know, in the prefix: [PATCH v5] network:

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-11-11 Thread Chen, Hanxiao
-Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Eric Blake Sent: Tuesday, November 11, 2014 7:13 AM To: Anirban Chakraborty; Michal Privoznik; libvir-list@redhat.com Subject: Re: [libvirt] [PATCH] network: Add bandwidth

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-11-11 Thread Eric Blake
: Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface On 11/10/2014 03:41 PM, Anirban Chakraborty wrote: BTW: it would be nice if you can version you patches. I mean, this is what, 4th or 5th version? Say that in subject explicitly please. You know, in the prefix: [PATCH

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-11-10 Thread Anirban Chakraborty
On 11/3/14, 2:58 AM, Michal Privoznik mpriv...@redhat.com wrote: On 30.10.2014 00:56, Anirban Chakraborty wrote: snip +static inline bool virNetDevSupportBandwidth(virDomainNetType type) +{ +switch (type) { +case VIR_DOMAIN_NET_TYPE_BRIDGE: +case VIR_DOMAIN_NET_TYPE_NETWORK:

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-11-10 Thread Eric Blake
On 11/10/2014 03:41 PM, Anirban Chakraborty wrote: BTW: it would be nice if you can version you patches. I mean, this is what, 4th or 5th version? Say that in subject explicitly please. You know, in the prefix: [PATCH v5] network: ... Using 'git send-email -v5' will do that for you. I was

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-11-03 Thread Michal Privoznik
On 30.10.2014 00:56, Anirban Chakraborty wrote: Ethernet interfaces in libvirt currently do not support bandwidth setting. For example, following xml file for an interface will not apply these settings to corresponding qdiscs. interface type=ethernet mac address=02:36:1d:18:2a:e4/

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-10-31 Thread Anirban Chakraborty
Ping ? On 10/29/14, 4:56 PM, Anirban Chakraborty abc...@juniper.net wrote: Ethernet interfaces in libvirt currently do not support bandwidth setting. For example, following xml file for an interface will not apply these settings to corresponding qdiscs. interface type=ethernet mac

[libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-10-29 Thread Anirban Chakraborty
Ethernet interfaces in libvirt currently do not support bandwidth setting. For example, following xml file for an interface will not apply these settings to corresponding qdiscs. interface type=ethernet mac address=02:36:1d:18:2a:e4/ model type=virtio/ script path=/